Issue metadata
Sign in to add a comment
|
Regression: 'Highlight text caret' is not working properly |
||||||||||||||||||||||||
Issue descriptionChrome Version:71.0.3544.0/11054.0.0 dev channel Kip,Reks,Daisy OS: Chrome OS What steps will reproduce the problem? (1)Recover build >> Sign into user >> Open chrome://settings page (2)From Ubertray/Accessibility >> Enable 'Highlight text caret' (3)Type something in any text fields and observe no highlight text caret Actual: 'Highlight text caret' is not working properly Expected:'Highlight text caret' should work properly i.e,should be seen highlighted on text fields while entering text This is a Regression issue as same is working fine in 70.0.3501.0/10908.0.0 dev Note: ----- 1.Issue is also seen in text fields of OOBE (Ex: Join WiFi overlay password field) 2.Issue is only not seen in Omnibox suggest 3.Able to repro the issue in all other text fields Attached the screencast for reference..
,
Sep 14
,
Sep 21
,
Sep 21
Chrome 71.0.3555.0 canary on Eve I am able to reproduce in the search field in chrome://settings and in the WiFi details dialog. Highlight text caret does work in Omnibox only.
,
Sep 21
I'll find an owner and put this through our triage process. Removing jennyz@chromium.org, patricialor@chromium.org as such.
,
Sep 21
,
Sep 24
Narrowed down bisect to 578400 (working), 578500 (broken) Suspecting: r578473 https://chromium-review.googlesource.com/1151897 "chromeos: Support a11y caret highlight in shortcut viewer app and mash"
,
Sep 24
Yes, this is me. Sorry about that. Note to self: CL was landed, reverted, and relanded: https://chromium-review.googlesource.com/c/chromium/src/+/1151897 https://chromium-review.googlesource.com/c/chromium/src/+/1152593 https://chromium-review.googlesource.com/c/chromium/src/+/1152373 Reland was r578473 Reproduces with linux-chromeos Manual revert of the last CL fixes the issue, but there are a large number of conflicts and it would be hard to backport the revert. I'll see if I can find a smaller fix.
,
Sep 24
An incidental piece of cleanup in my CL was wrong. Text carets can have zero width but still be valid. Fix up at https://chromium-review.googlesource.com/c/chromium/src/+/1241215
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab7033b303d79fae929891b047098a4ab31ef50b commit ab7033b303d79fae929891b047098a4ab31ef50b Author: James Cook <jamescook@chromium.org> Date: Mon Sep 24 21:17:28 2018 chromeos: Fix accessibility text caret highlight in web contents The text insertion caret in web contents can have a positive height but zero width. Ensure the a11y highlight is still visible in this case. This regressed in: https://chromium-review.googlesource.com/c/chromium/src/+/1152373 due to the change to AccessibilityHighlightController::IsCaretVisible. Bug: 882762 Test: added to ash_unittests Change-Id: I2743cb234b49eb5c0d71ba5bf1d25e3869c2492f Reviewed-on: https://chromium-review.googlesource.com/1241215 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#593681} [modify] https://crrev.com/ab7033b303d79fae929891b047098a4ab31ef50b/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/ab7033b303d79fae929891b047098a4ab31ef50b/ash/accessibility/accessibility_highlight_controller_unittest.cc
,
Sep 24
Manually verified on device on eve.
,
Sep 25
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23ea97234e745c4b562f6d5a1c3e653d8202c6a1 commit 23ea97234e745c4b562f6d5a1c3e653d8202c6a1 Author: James Cook <jamescook@chromium.org> Date: Tue Sep 25 15:26:11 2018 M70: chromeos: Fix accessibility text caret highlight in web contents The text insertion caret in web contents can have a positive height but zero width. Ensure the a11y highlight is still visible in this case. This regressed in: https://chromium-review.googlesource.com/c/chromium/src/+/1152373 due to the change to AccessibilityHighlightController::IsCaretVisible. Bug: 882762 Test: added to ash_unittests Change-Id: I2743cb234b49eb5c0d71ba5bf1d25e3869c2492f Reviewed-on: https://chromium-review.googlesource.com/1241215 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593681}(cherry picked from commit ab7033b303d79fae929891b047098a4ab31ef50b) Reviewed-on: https://chromium-review.googlesource.com/1243165 Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#652} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/23ea97234e745c4b562f6d5a1c3e653d8202c6a1/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/23ea97234e745c4b562f6d5a1c3e653d8202c6a1/ash/accessibility/accessibility_highlight_controller_unittest.cc
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23ea97234e745c4b562f6d5a1c3e653d8202c6a1 Commit: 23ea97234e745c4b562f6d5a1c3e653d8202c6a1 Author: jamescook@chromium.org Commiter: jamescook@chromium.org Date: 2018-09-25 15:26:11 +0000 UTC M70: chromeos: Fix accessibility text caret highlight in web contents The text insertion caret in web contents can have a positive height but zero width. Ensure the a11y highlight is still visible in this case. This regressed in: https://chromium-review.googlesource.com/c/chromium/src/+/1152373 due to the change to AccessibilityHighlightController::IsCaretVisible. Bug: 882762 Test: added to ash_unittests Change-Id: I2743cb234b49eb5c0d71ba5bf1d25e3869c2492f Reviewed-on: https://chromium-review.googlesource.com/1241215 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593681}(cherry picked from commit ab7033b303d79fae929891b047098a4ab31ef50b) Reviewed-on: https://chromium-review.googlesource.com/1243165 Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#652} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 25
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dgagnon@chromium.org
, Sep 14