New issue
Advanced search Search tips

Issue 882747 link

Starred by 1 user
Status: Fixed
Owner:
dats@chromium.org
Closed: Dec 28
Cc:
amistry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 864313



Sign in to add a comment

Copying file bigger than free space attempts copy and fails, instead of disallowing copy.

Project Member Reported by amistry@chromium.org, Sep 11 
Chrome Version: 71
OS: Chrome

What steps will reproduce the problem?
1. Insert USB drive.
2. Copy file to drive, bigger than free space (i.e. copy 1G file to drive with 512M free space).

What is the expected result?
Copy should be disallowed, with message saying "Not enough free space".

What happens instead?
Copy is started, continues until drive is full, then message appears in the notification center saying "Copy operation failed. There is not enough space."

Also, the half-copied file remains on the USB drive, see https://crbug.com/170295

Comment 1 by slangley@chromium.org, Sep 16

Status: Available (was: Untriaged)

Comment 2 by slangley@chromium.org, Nov 16

Labels: Files-Fixit-2018

Comment 3 by dats@chromium.org, Nov 20

Owner: dats@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fab086276c31650069f4bb5013180db9a0c5f8e

commit 8fab086276c31650069f4bb5013180db9a0c5f8e
Author: Sergei Datsenko <dats@chromium.org>
Date: Fri Dec 28 04:23:49 2018

Check if the destination has enough space before copying into it

For some reason the copy operation was checking for space not the destination,
but always Downloads. Also the source size wasn't calculated correctly if it's
a dir.

BUG= chromium:882747 

Change-Id: I5749fbb65907ff5be29b20610f82fbbd5c5e3372
Reviewed-on: https://chromium-review.googlesource.com/c/1379629
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619115}
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/chrome/browser/sync_file_system/local/local_file_change_tracker.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/async_file_util_adapter.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/async_file_util_adapter.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/dragged_file_util.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/dragged_file_util.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/dragged_file_util_unittest.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/file_system_file_util.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/file_system_operation.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/local_file_util.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/local_file_util.h
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/obfuscated_file_util.cc
[modify] https://crrev.com/8fab086276c31650069f4bb5013180db9a0c5f8e/storage/browser/fileapi/obfuscated_file_util.h

Comment 5 by dats@chromium.org, Dec 28

Status: Fixed (was: Started)
►

Sign in to add a comment