CRAS: periodic click in recording with AEC enabled. |
||||||
Issue descriptionWhat steps will reproduce the problem? cras_test_client --capture_file /tmp/1 --effects aec What is the expected result? Good recording. What happens instead? When listen to the recorded file, there's a periodic clicking. It's easier to notice the click sound when record something loud.
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/516fa196e0ca848d12852fd2772e31ef54710c57 commit 516fa196e0ca848d12852fd2772e31ef54710c57 Author: Hsin-Yu Chao <hychao@google.com> Date: Thu Sep 13 13:14:07 2018 CRAS: input_data - Use offset for copy at buffer wrap When input_data's circular buffer wraps, one buffer copy breaks into two steps of smaller buffer copy. The second copy needs correct offset. Before this fix, there will be 8192/48000= 0.17 seconds periodic clicking sound due to discontinuity. BUG= chromium:882742 TEST=cras_test_client --capture_file /tmp/1 --effects aec to record some loud sound, and listen to the recorded file to verify there's no periodic clicking sound. Change-Id: I0e02784ca8ea121768b7a513dbbc5f2733e8c43e Reviewed-on: https://chromium-review.googlesource.com/1218204 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/516fa196e0ca848d12852fd2772e31ef54710c57/cras/src/server/input_data.c
,
Sep 13
The fix has been verified. Request merge to M70.
,
Sep 13
Approved for M70
,
Sep 13
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/f39de65a82c3d159cd7bca82727d816d6b51b750 commit f39de65a82c3d159cd7bca82727d816d6b51b750 Author: Hsin-Yu Chao <hychao@google.com> Date: Fri Sep 14 06:22:00 2018 CRAS: input_data - Use offset for copy at buffer wrap When input_data's circular buffer wraps, one buffer copy breaks into two steps of smaller buffer copy. The second copy needs correct offset. Before this fix, there will be 8192/48000= 0.17 seconds periodic clicking sound due to discontinuity. BUG= chromium:882742 TEST=cras_test_client --capture_file /tmp/1 --effects aec to record some loud sound, and listen to the recorded file to verify there's no periodic clicking sound. Change-Id: I0e02784ca8ea121768b7a513dbbc5f2733e8c43e Reviewed-on: https://chromium-review.googlesource.com/1218204 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit 516fa196e0ca848d12852fd2772e31ef54710c57) Reviewed-on: https://chromium-review.googlesource.com/1226771 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/f39de65a82c3d159cd7bca82727d816d6b51b750/cras/src/server/input_data.c
,
Sep 14
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hychao@chromium.org
, Sep 11