New issue
Advanced search Search tips

Issue 882698 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Incorrect info about Camera/Microphone with revoked system permissions in Site Settings

Project Member Reported by mar...@mwiacek.com, Sep 11

Issue description

Steps to reproduce:
(0)remove Android permissions for Camera/Microphone
(1)open Settings
(2)open Site settings

Expected result:
Blocked info

Actual result:
Ask first info

Proposed patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1218142
 
bug.png
98.6 KB View Download
patch.png
100 KB View Download
Labels: Needs-triage-Mobile
Cc: chelamcherla@chromium.org
Labels: Triaged-Mobile
Could someone from UI>Browser>SiteSettings team please have a look at proposed patch mentioned in comment#0. 

Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858e77340f1427865c73160d73149dc977c2c5ad

commit 858e77340f1427865c73160d73149dc977c2c5ad
Author: Marcin Wiacek <marcin@mwiacek.com>
Date: Tue Sep 11 21:11:08 2018

Fix for status for Camera & Microphone with disabled permissions

When system permissions are disabled for Camera / Microphone,
Chrome displays "Ask first" in Settings/Site Settings.

Patch is changing it to "Blocked" + doing one micro-optimization
as small bonus.

BUG= 882698 

Change-Id: Ie061803b0de805c7fbc3c11c698afcceeda082fe
Reviewed-on: https://chromium-review.googlesource.com/1218142
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590473}
[modify] https://crrev.com/858e77340f1427865c73160d73149dc977c2c5ad/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java

Owner: mar...@mwiacek.com
Status: Assigned (was: Unconfirmed)
As per comment#3 changing the status to Assigned and assigning to marcin@
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Works as per expected behavior, Issue verified on 71.0.3552.0

Sign in to add a comment