New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882691 link

Starred by 0 users
Status: Fixed
Owner:
█ tgu...@chromium.org
Last visit > 30 days ago
Closed: Sep 25
Cc:
yyushkina@chromium.org
█ ainslie@chromium.org
█ ramyan@chromium.org
bklmn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
NTP-Birthday-Polish


Sign in to add a comment

Rename prepopulated page title for Chrome Web Store

Project Member Reported by ramyan@chromium.org, Sep 11 
From ainslie@:

https://screenshot.googleplex.com/yOGw1bxoXRN.png in a fresh profile, we only put one shortcut to the webstore on the NTP. Should we shorten the title so that we don't need to use the "...". I notice on the chrome://apps page for example we just call it "Web Store".

Comment 1 by ramyan@chromium.org, Sep 11 

Yana: not sure if this was already tracked somewhere - please close as a dupe if it is.

Comment 2 by twelling...@chromium.org, Sep 11

Labels: zine-triaged

Comment 3 by ramyan@chromium.org, Sep 12

Owner: ramyan@chromium.org
Status: Assigned (was: Available)

Comment 4 by tgu...@chromium.org, Sep 20

Owner: tgu...@chromium.org

Comment 5 by ramyan@chromium.org, Sep 25

Cc: ainslie@chromium.org
+ainslie: I just realized I didn't cc you on this bug captured from our email thread on 8/28/18.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad7487aa7b9db4394b510901118ab73d7dd5a26

commit 2ad7487aa7b9db4394b510901118ab73d7dd5a26
Author: Tanya Gupta <tgupta@chromium.org>
Date: Tue Sep 25 21:25:18 2018

Shortened title for Chrome Webstore Icon on the New Tab Page


R=ramyan@chromium.org

Change-Id: I72f5f094f4f637d324c1fbbd66cdbc39f4327f6f

Bug:  882691 
Change-Id: I72f5f094f4f637d324c1fbbd66cdbc39f4327f6f
Reviewed-on: https://chromium-review.googlesource.com/1241837
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594109}
[modify] https://crrev.com/2ad7487aa7b9db4394b510901118ab73d7dd5a26/chrome/app/generated_resources.grd
[modify] https://crrev.com/2ad7487aa7b9db4394b510901118ab73d7dd5a26/chrome/browser/history/top_sites_factory.cc

Comment 7 by tgu...@chromium.org, Sep 25

Status: Fixed (was: Assigned)

Comment 8 by jbanavatu@chromium.org, Sep 26

Labels: TE-Verified-M71 TE-Verified-71.0.3562.0
Able to reproduce this issue on build without fix hence verifying the fix on latest canary 71.0.3562.0 using Mac 10.13.6, Windows 10 and Debian.

Now Chrome webstore title is changed to webstore in NTP of a fresh profile . Attaching screenshot for reference.

As fix is working as expected adding Verified labels.

Thanks!
Screen Shot 2018-09-26 at 5.17.04 PM.png
326 KB View Download
►

Sign in to add a comment