New issue
Advanced search Search tips

Issue 882660 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Blink accessibility onion soup: get rid of content/renderer/accessibility

Project Member Reported by dmazz...@chromium.org, Sep 10

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09be59de27ba4d6e59e74fe66c111394514d73fa

commit 09be59de27ba4d6e59e74fe66c111394514d73fa
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Sep 12 19:31:09 2018

Replace blink event enums with ax::mojom::Event

This removes some unnecessary abstractions and helps
with mojoification of Blink accessibility, and eventually
will help us to remove all of the code in
content/renderer/accessibility.

Bug: 882660

Change-Id: I6170c78abbfbe57972d15b73fb2fd33523472bec
Reviewed-on: https://chromium-review.googlesource.com/1217906
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590786}
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/accessibility/render_accessibility_impl.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/renderer/render_frame_impl.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/shell/test_runner/web_frame_test_proxy.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/public/web/DEPS
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/DEPS
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_list_box.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_menu_list.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_menu_list_popup.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_radio_input.cc
[modify] https://crrev.com/09be59de27ba4d6e59e74fe66c111394514d73fa/third_party/blink/renderer/modules/accessibility/ax_virtual_object.cc

Hi All,

this change broke cross-compile builds for both ARM and MIPS with same error.

Reported error is:

$ time ninja -C out/arm -j4 content_shell
ninja: Entering directory `out/arm'
[39420/44253] CXX clang_x86_v8_arm/obj/third_party/blink/renderer/core/aom/aom/computed_accessible_node.o
FAILED: clang_x86_v8_arm/obj/third_party/blink/renderer/core/aom/aom/computed_accessible_node.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF clang_x86_v8_arm/obj/third_party/blink/renderer/core/aom/aom/computed_accessible_node.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"340925-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DCR_SYSROOT_HASH=8fa6886026aed66e5c3056a1498490d23ccc9ae1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DENABLE_IPC_FUZZER -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DWTF_USE_WEBAUDIO_FFMPEG=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DV8_DEPRECATION_WARNINGS -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Iclang_x86_v8_arm/gen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Iclang_x86_v8_arm/gen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Iclang_x86_v8_arm/gen/angle -I../../third_party/libjpeg_turbo -I../../v8/include -Iclang_x86_v8_arm/gen/v8/include -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Iclang_x86_v8_arm/gen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -no-canonical-prefixes -fcomplete-member-pointers -m32 -msse2 -mfpmath=sse -mmmx -momit-leaf-frame-pointer -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Wglobal-constructors -g0 -isystem../../build/linux/debian_sid_i386-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_sid_i386-sysroot/usr/lib/i386-linux-gnu/glib-2.0/include -Wno-header-guard -isystem../../build/linux/debian_sid_i386-sysroot/usr/include/nss -isystem../../build/linux/debian_sid_i386-sysroot/usr/include/nspr -DLIBXML_STATIC= -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_i386-sysroot -fvisibility-inlines-hidden -c ../../third_party/blink/renderer/core/aom/computed_accessible_node.cc -o clang_x86_v8_arm/obj/third_party/blink/renderer/core/aom/aom/computed_accessible_node.o
In file included from ../../third_party/blink/renderer/core/aom/computed_accessible_node.cc:11:
../../third_party/blink/public/web/web_local_frame_client.h:77:10: fatal error: 'ui/accessibility/ax_enums.mojom-shared.h' file not found
#include "ui/accessibility/ax_enums.mojom-shared.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Needed header file exists at:

out/arm/gen/ui/accessibility/

but during build for clang_x86_v8_arm, include path has -Iclang_x86_v8_arm/gen, and this directory does not contain the ui/accessibility.

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59e6785934006e48d10379c1d74f42c47866128

commit f59e6785934006e48d10379c1d74f42c47866128
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Sep 20 07:42:41 2018

Replace blink role enums with ax::mojom::Role

This removes some unnecessary abstractions and helps
with mojoification of Blink accessibility, and eventually
will help us to remove all of the code in
content/renderer/accessibility.

Bug: 882660
Change-Id: I504876e4ec5d7a50c439031b66c3d8d2525109e9
Reviewed-on: https://chromium-review.googlesource.com/1226200
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592711}
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/public/web/web_ax_object.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/BUILD.gn
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/DEPS
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/accessibility_object_model_test.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_enums.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_enums.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_image_map_link.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_image_map_link.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_inline_text_box.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list_box.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list_box.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list_box_option.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_list_box_option.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_menu_list.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_menu_list.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_menu_list_option.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_menu_list_option.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_menu_list_popup.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_object_test.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_position_test.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_progress_indicator.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_progress_indicator.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_range_test.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_slider.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_slider.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_svg_root.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/ax_svg_root.h
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/accessibility/inspector_type_builder_helper.cc
[modify] https://crrev.com/f59e6785934006e48d10379c1d74f42c47866128/third_party/blink/renderer/modules/exported/web_ax_object.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb995f42a39339bfb774e20828960b7cfc9a0e4

commit bdb995f42a39339bfb774e20828960b7cfc9a0e4
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Sep 21 07:37:00 2018

Replace more blink accessibility enums with mojo enums.

Follow-up to other similar patches. This removes several
more small enums that were nearly identical to ones
defined in ui/accessibility/ax_enums.mojom.

This time I added a couple of new enum values to
ui/accessibility/ax_enums.mojom in order to synchronize
them with the Blink enums. Those changes shouldn't
affect any real logic.

TBR=tsepez@chromium.org

Bug: 882660
Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3a7556254794097e629837576a44ce477d498f87
Reviewed-on: https://chromium-review.googlesource.com/1236270
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593101}
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/test/data/accessibility/aria/aria-sort-aria-grid-expected-win.txt
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/test/data/accessibility/aria/aria-sort-html-table-expected-win.txt
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/content/test/data/accessibility/html/a-name-calc-expected-blink.txt
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/public/web/web_ax_object.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/core/editing/markers/document_marker.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/core/editing/text_affinity.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/accessibility_object_model_test.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_enums.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_enums.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_inline_text_box.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_inline_text_box.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_list_box_option.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_list_box_option.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_media_controls.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_menu_list_option.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_menu_list_option.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_node_object.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_node_object.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_virtual_object.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/ax_virtual_object.h
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/accessibility/inspector_type_builder_helper.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/bdb995f42a39339bfb774e20828960b7cfc9a0e4/ui/accessibility/ax_enums.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35e821599fb776a15bb8be9b30fd77eb7058bf73

commit 35e821599fb776a15bb8be9b30fd77eb7058bf73
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Oct 31 00:21:50 2018

Replace blink::TextStyle enum with ax::mojom::TextStyle

Follow-up to other similar patches.

This also fixes ax::mojom::TextStyle so that it
just encodes the possible flags for the bit fields,
rather than trying to encode every permutation of bits.

Bug: 882660
TBR=halliwell@chromium.org

Change-Id: If16be583e6ee35728116b568334b1b89aad0b2ef
Reviewed-on: https://chromium-review.googlesource.com/c/1300414
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604074}
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/content/test/data/accessibility/css/font-style-expected-win.txt
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/public/web/web_ax_object.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/accessibility/ax_enums.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/accessibility/ax_enums.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/accessibility/ax_layout_object.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/third_party/blink/renderer/modules/exported/web_ax_object.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/ui/accessibility/ax_assistant_structure.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/35e821599fb776a15bb8be9b30fd77eb7058bf73/ui/accessibility/ax_node_data.h

Sign in to add a comment