MultiDeviceSetup flow: change PasswordPage secondary button from Cancel to Back |
||||
Issue descriptionThe PasswordPage should have a Back button, instead of a Cancel button, in order to allow the user to navigate back to the StartPage so that they can change their choice of host device. Not a launch blocker, but a nice-to-have stretch goal. (Associating with deprecated ProximityAuth component for now because no MultiDevice component exists yet)
,
Sep 20
,
Sep 28
Now the mocks show Back and Cancel buttons. See https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view. Also, we will need to add a "Back" string for this unless we plan to use https://cs.chromium.org/chromium/src/chrome/app/chromeos_strings.grdp?l=1296-1298&rcl=f369a29a01b3d8e8269afae32157f3e4e7ec7e3f or https://cs.chromium.org/chromium/src/components/components_strings.grd?l=295-297&rcl=f369a29a01b3d8e8269afae32157f3e4e7ec7e3f.
,
Sep 28
We don't even have a password page in OOBE mode, so I'm certain those mocks are either out of date or are simply incorrect. We still want to add a "Back" button. Regarding the string, you should add your own string and add its translation to https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc.
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68ae2b689e8cf40c9bb3a8eab948fbb87d29b844 commit 68ae2b689e8cf40c9bb3a8eab948fbb87d29b844 Author: Josh Nohle <nohle@google.com> Date: Sat Sep 29 01:19:04 2018 [CrOS MultiDevice] Add string for Back button Bug: 882647 Change-Id: I358d737e7b2e073d42d1e7da7825a5d0e378a9aa Reviewed-on: https://chromium-review.googlesource.com/1252841 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#595282} [modify] https://crrev.com/68ae2b689e8cf40c9bb3a8eab948fbb87d29b844/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/68ae2b689e8cf40c9bb3a8eab948fbb87d29b844/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc
,
Oct 1
,
Oct 2
crbug/889574 and specifically the mocks at https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view mention adding a "Back" button in addition to a "Cancel" button. Closing in favor of that bug. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jlklein@chromium.org
, Sep 20Status: Assigned (was: Available)