New issue
Advanced search Search tips

Issue 882631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ASAN test failure - ExtensionWebRequestApiTest.WebRequestTypes with SingleProcessMash enabled

Project Member Reported by rcui@chromium.org, Sep 10

Issue description

Transplanting conversation from  crbug.com/874090 : 

gab@:

ExtensionWebRequestApiTest.WebRequestTypes are failing consistently on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 since battre@ stopped them from outright timing out through r589864.

Example failure : https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935751851391670800/+/steps/single_process_mash_browser_tests/0/logs/ExtensionWebRequestApiTest.WebRequestTypes/0

battre@:

The CM API tests have a list of events that are expected and here it complains about an unexpected event. It is unexpected because the actual event does not have a valid frameId, parentFrameId and tabId. It is expected that the "onResponseStarted" event is associated with the tab in which the request was triggered.

The data is populated in WebRequestEventDetails::SetFrameData. +karandeepb worked last on extensions/browser/extension_api_frame_id_map.*.

karandeepb@:

Is there supposed to be something special about this test config? This seems to run ok on the other trybots - https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=ExtensionWebRequestApiTest.WebRequestTypes.

rcui@:

It looks like the failure is particular to the ASAN bot.  The test passes in single_process_mash_browser_tests on other bots - linux-chromeos-rel, linux-chromeos-dbg: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=single_process_mash_browser_tests&tests=ExtensionWebRequestApiTest.WebRequestTypes

karandeepb@:

Not sure on what the reason is. You can file a bug and add it to the filter file for now, I think.

 
Components: Platform>Extensions
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036dd350148a7c4be0f3c41f5d8ea860db6ec1a9

commit 036dd350148a7c4be0f3c41f5d8ea860db6ec1a9
Author: Ryan Cui <rcui@chromium.org>
Date: Tue Sep 11 17:18:47 2018

Filter file update for single_process_mash_browser_test

Add blacklist for CrSettingsResetPageTest.All (flaky) and
ExtensionWebRequestApiTest.WebRequestTypes (failing on ASAN bot).

Bug:  874090 
Bug:  882631 
Bug:  880584 
Change-Id: Ie2a5bee8de4497a470a064ea853805a0e74b685a
Reviewed-on: https://chromium-review.googlesource.com/1217710
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590366}
[modify] https://crrev.com/036dd350148a7c4be0f3c41f5d8ea860db6ec1a9/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Owner: karandeepb@chromium.org
Status: Assigned (was: Untriaged)
Triage: karandeepb@ is probably most familiar with this area.
I ran this test 31 times and it never failed. I'm going to reenable.
Owner: sky@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/264cb9cde1d16be7d257e4c16ca876759a4187da

commit 264cb9cde1d16be7d257e4c16ca876759a4187da
Author: Scott Violet <sky@chromium.org>
Date: Mon Dec 10 17:57:44 2018

chromeos: reenable ExtensionWebRequestApiTest.WebRequestTypes

I was unable to reproduce locally. Am going to reenable. If flakes more,
will investigate.

BUG= 882631 
TEST=test only change
TBR=karandeepb@chromium.org

Change-Id: I4bc07964ff30f6475f808c193f1c26db468d6775
Reviewed-on: https://chromium-review.googlesource.com/c/1370174
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615169}
[modify] https://crrev.com/264cb9cde1d16be7d257e4c16ca876759a4187da/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment