New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882627 link

Starred by 2 users
Status: Fixed
Owner:
█ hubbe@chromium.org
Last visit > 30 days ago
Closed: Sep 19
Cc:
ccameron@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

GPU Memory Buffers don't handle full-range video on Mac

Project Member Reported by hubbe@chromium.org, Sep 10 
Macs are supposed to handle full-range video by changing the pixel format to a full range value (420f) but doing so doesn't seem to work. Until we figure out how to make full-range YUV iosurfaces work on mac, we'll need to avoid using them that way.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554e1811b91fb8cf0e70e8916977cdb9e01085d6

commit 554e1811b91fb8cf0e70e8916977cdb9e01085d6
Author: Hubbe Hubinette <hubbe@chromium.org>
Date: Thu Sep 13 20:08:18 2018

Disable GMB on mac for full-range video

...and enable the full-range-video test on mac.
This will only affect software decoded video frames as
hardware-decoded video frames seem to be converted to studio
range on mac.

Bug:  647838 , 810908,  882627 
Change-Id: I318d1480dff4f33fa4da4312bead4b6d09f1a810
Reviewed-on: https://chromium-review.googlesource.com/1164462
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591127}
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/content/browser/media/media_color_browsertest.cc
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-no-audio-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac/media/video-colorspace-yuv420-expected.png
[modify] https://crrev.com/554e1811b91fb8cf0e70e8916977cdb9e01085d6/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png

Comment 2 by hubbe@chromium.org, Sep 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment