cr-input readonly highlights only on tab backwards |
||
Issue descriptionRepro: 1. Navigate to a Settings page using 'readonly' input fields (Internet > Details > Network or Printing > Printers > Edit printer) 2. Tab to a readonly field. 3. Tab past that field, then shift-tab back to the field. Observe: Tabbing forward to the field does not select the text, but tabbing backwards to the field does. Expected: Tabing in either direction should be consistent. Also: When a field is not 'readonly', tabbing forward to the field does not select the contents, but tabbing backwards does. This should also be consistent. A regular <input> element selects the contents when focused.
,
Sep 10
I have a fairly simple fix up for review. I will definitely wait for Scott to review it (https://chromium-review.googlesource.com/c/chromium/src/+/1217747).
,
Sep 11
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a733daaab037e63fe5474be68c6e5877c9c670 commit 54a733daaab037e63fe5474be68c6e5877c9c670 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Sep 11 17:04:35 2018 cr-input: select input element when focused Currently we select the input element contents when focusing back to a <cr-input> element with shift-tab, but focusing forward to a <cr-input> element does not select its contents. This fixes that behavior to always select the contents to be consistent with the behavior of <input>. Bug: 882612 Change-Id: Iecfbd984928571ca7041133f5621d82fd32f4f35 Reviewed-on: https://chromium-review.googlesource.com/1217747 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590357} [modify] https://crrev.com/54a733daaab037e63fe5474be68c6e5877c9c670/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/54a733daaab037e63fe5474be68c6e5877c9c670/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js [modify] https://crrev.com/54a733daaab037e63fe5474be68c6e5877c9c670/ui/webui/resources/cr_elements/cr_input/cr_input.js
,
Sep 11
,
Dec 18
This change has caused a regression in FilesApp when focus() is called, see https://bugs.chromium.org/p/chromium/issues/detail?id=914741 The call to select() is causing the regression. |
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Sep 10