New issue
Advanced search Search tips

Issue 882609 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in sk_abort_no_print

Project Member Reported by ClusterFuzz, Sep 10

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6219994088865792

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900006d87
Crash State:
  sk_abort_no_print
  GrAAConvexTessellator::computeNormals
  GrAAConvexTessellator::computeNormals
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559542:559554

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6219994088865792

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 10

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 10

Cc: carycl...@skia.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

mapRect should not fiddle with nonfinite values. by caryclark@skia.org - https://skia.googlesource.com/skia/+/c06754b0466e14e1611fa3144bf337289e6ca82f

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: -carycl...@skia.org
Owner: bsalo...@google.com
Is this related to review.skia.org/150682 ?
Very well could be. Will investigate.
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/efa6bcb022d749bcb0ac7455aa9823af859115bd

commit efa6bcb022d749bcb0ac7455aa9823af859115bd
Author: Brian Salomon <bsalomon@google.com>
Date: Tue Sep 11 17:59:57 2018

Make GrAAConvexTessellator bail on paths that map to inf/nan in device space.

This makes us avoid hitting assertions when computing normals.

We could be better and clip but have to be careful about strokes.

Bug:  882609 
Change-Id: I6550e7f8b912021fb8dfbcad7a03151dfb272b11
Reviewed-on: https://skia-review.googlesource.com/153664
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/efa6bcb022d749bcb0ac7455aa9823af859115bd/src/gpu/ops/GrAAConvexTessellator.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6080d05526ff118e6df285592cb0eb1632d38890

commit 6080d05526ff118e6df285592cb0eb1632d38890
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 11 21:02:14 2018

Roll src/third_party/skia fb18639804e7..e6146bd7be6f (4 commits)

https://skia.googlesource.com/skia.git/+log/fb18639804e7..e6146bd7be6f


git log fb18639804e7..e6146bd7be6f --date=short --no-merges --format='%ad %ae %s'
2018-09-11 jvanverth@google.com Fix float overflow in shadow tessellator
2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0d0fb43f34ee..2da04538b4ff (2 commits)
2018-09-11 fmalita@chromium.org Reland: add SkPath::shrinkToFit
2018-09-11 bsalomon@google.com Make GrAAConvexTessellator bail on paths that map to inf/nan in device space.


Created with:
  gclient setdep -r src/third_party/skia@e6146bd7be6f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:882609 
TBR=caryclark@chromium.org

Change-Id: I0db5cee64e208a6b6bc158ce8f82ebc97b0166c5
Reviewed-on: https://chromium-review.googlesource.com/1220233
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590468}
[modify] https://crrev.com/6080d05526ff118e6df285592cb0eb1632d38890/DEPS

Project Member

Comment 8 by ClusterFuzz, Sep 12

ClusterFuzz has detected this issue as fixed in range 590455:590472.

Detailed report: https://clusterfuzz.com/testcase?key=6219994088865792

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900006d87
Crash State:
  sk_abort_no_print
  GrAAConvexTessellator::computeNormals
  GrAAConvexTessellator::computeNormals
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559542:559554
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=590455:590472

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6219994088865792

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Sep 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6219994088865792 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment