Offline indicator should be dismissed when top toolbar moves |
|||||||
Issue descriptionWhen the user scroll the page, the top toolbar will move up or down. Offline indicator banner does not move at the same time. Also, offline indicator does not work well when Chrome Duet mode is enabled.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a6a397bcb33f7f0f8e866654f0032c17af5a1d commit 67a6a397bcb33f7f0f8e866654f0032c17af5a1d Author: Jian Li <jianli@chromium.org> Date: Tue Sep 11 00:58:02 2018 Dismiss top snackbar move when top toolbar moves Also do not associate the top snackbar view with bottom container view in order to make it also work with Duet mode enabled. Bug: 882596 Change-Id: I34ed55cc6bc90ff705e488914773d7be116087df Reviewed-on: https://chromium-review.googlesource.com/1217590 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#590150} [modify] https://crrev.com/67a6a397bcb33f7f0f8e866654f0032c17af5a1d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java [modify] https://crrev.com/67a6a397bcb33f7f0f8e866654f0032c17af5a1d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarView.java [modify] https://crrev.com/67a6a397bcb33f7f0f8e866654f0032c17af5a1d/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
,
Sep 11
,
Sep 12
Verified in 71.0.3550.0
,
Sep 13
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
Approved for merge into 70, branch 3538.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57a42a8024f9d60e7e46ffaaa3e4c6146ebdfd03 commit 57a42a8024f9d60e7e46ffaaa3e4c6146ebdfd03 Author: Jian Li <jianli@chromium.org> Date: Fri Sep 14 18:24:37 2018 Merge M70: Dismiss top snackbar move when top toolbar moves Also do not associate the top snackbar view with bottom container view in order to make it also work with Duet mode enabled. TBR=jianli@chromium.org (cherry picked from commit 67a6a397bcb33f7f0f8e866654f0032c17af5a1d) Bug: 882596 Change-Id: I34ed55cc6bc90ff705e488914773d7be116087df Reviewed-on: https://chromium-review.googlesource.com/1217590 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590150} Reviewed-on: https://chromium-review.googlesource.com/1226361 Reviewed-by: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#411} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/57a42a8024f9d60e7e46ffaaa3e4c6146ebdfd03/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java [modify] https://crrev.com/57a42a8024f9d60e7e46ffaaa3e4c6146ebdfd03/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarView.java [modify] https://crrev.com/57a42a8024f9d60e7e46ffaaa3e4c6146ebdfd03/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
,
Sep 14
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jianli@chromium.org
, Sep 102.1 MB
2.1 MB View Download