lquinn@: Please provide alternate .apk file as on navigating to  https://github.com/pacificregmi/SimpleAndroidWebViewExample seeing "There was an unexpected problem serving your request" error.

Thanks!

chelamcherla@, attached is the APK that I used to test this.

Deleted: app-debug.apk 1.0 MB

app-debug.apk 1.0 MB Download

Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

WebView has a different code path [1] for this than Chrome [2]. So the fix didn't affect WebView. We probably want to apply the same fix to WebView if that is what web spec suggested.

Assign to owner of  issue 737232 , feel free to unassign if you feel it is better for WebView team to own this bit.

[1] https://cs.chromium.org/chromium/src/android_webview/browser/net/aw_http_user_agent_settings.cc?rcl=98fe895533a521d1ac7f38627b86bb2dc718e3f7&l=22
[2] https://cs.chromium.org/chromium/src/chrome/browser/net/chrome_accept_language_settings.cc?rcl=d1cfec12f0f2dc76e54d5a37039cf110ad61dfc6&l=59

lquinn@, WebView doesn't necessarily have the same Accept Language value with Chrome for Android. Since Chrome has its own language setting other than system language setting, it may consult system language setting though.

So in your case, with two languages selected, I would expect the string to be something like "en-CA,en;q=0.9,fr-CA;q=0.8,fr;q=0.7,en-US;q=0.6" (hand made, didn't consult spec, may not be true, just to show we should have base language as you mentioned).

ctzsm@, yes, that makes sense.

 Issue 667705  has been merged into this issue.

WebView was somehow missed from the launch. I can take an initial look as claudiomagni@ seems idle.

This should be mostly fine, it requires the following work:
- moving the relevant code from chrome/browser/ to net/ and reusing it from webview
- fixing AcceptLanguageTest: currently the test assumes that navigator.languages have the same list as accept language list in useragentstring. Now it's no longer the case, which should be fine.
- fixing CTS (WebSettingsTest)

It would be nice to see a way to roll this out gracefully using Finch, but I don't have a clear idea what I can measure. I can still try to implement it behind a flag as a last resort, in case there is a serious compat issue.

Changwan, thank you for taking this issue. I currently don't have spare cycles to look at it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/656093235a0fc1d7c9d399deca7cd2a972939e2c

commit 656093235a0fc1d7c9d399deca7cd2a972939e2c
Author: Changwan Ryu <changwan@google.com>
Date: Tue Oct 16 23:55:55 2018

Move ExpandLanguageList from chrome/ to net/

Such that we can use it from android_webview/.

Bug:  882587 ,  737232 
Change-Id: I0006cabbdbb31dfbf1b36a67dd226fe54afe76a8
Reviewed-on: https://chromium-review.googlesource.com/c/1274598
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600196}
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/chrome/browser/BUILD.gn
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[delete] https://crrev.com/36f4d4de1f6244f3d7df3c08e13fbc7b16307419/chrome/browser/net/chrome_accept_language_settings.cc
[delete] https://crrev.com/36f4d4de1f6244f3d7df3c08e13fbc7b16307419/chrome/browser/net/chrome_accept_language_settings.h
[delete] https://crrev.com/36f4d4de1f6244f3d7df3c08e13fbc7b16307419/chrome/browser/net/chrome_accept_language_settings_unittest.cc
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/chrome/test/BUILD.gn
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/net/http/http_util.cc
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/net/http/http_util.h
[modify] https://crrev.com/656093235a0fc1d7c9d399deca7cd2a972939e2c/net/http/http_util_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e69858666859ef9861f605c8b38c336bc76b04f8

commit e69858666859ef9861f605c8b38c336bc76b04f8
Author: Changwan Ryu <changwan@google.com>
Date: Fri Oct 19 22:52:00 2018

Expand accept languages

Expand accept languages by adding base language from language-country
pair, using the same logic that Chrome is already using.
This aligns with this W3C doc:
https://www.w3.org/International/questions/qa-lang-priorities#langtagdetail

Currently not behind a feature, will be followed by a change to use a
feature.
Also slightly refactoring tests to improve readability.

Bug:  882587 ,  737232 
Change-Id: I1e067bde4ae5b00b6b7c3be765a9cd97bbbb96df
Reviewed-on: https://chromium-review.googlesource.com/c/1286936
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601334}
[modify] https://crrev.com/e69858666859ef9861f605c8b38c336bc76b04f8/android_webview/browser/net/aw_http_user_agent_settings.cc
[modify] https://crrev.com/e69858666859ef9861f605c8b38c336bc76b04f8/android_webview/javatests/src/org/chromium/android_webview/test/AcceptLanguageTest.java

Marking as fixed for now, although I'm thinking of adding a feature flag. It will target M72.

Verified on Black berry KKey oneNMF26F ,issue mentioned no longer reproducibleon latest 72 .Please mark it verified on the latest 72 build once available.