New issue
Advanced search Search tips

Issue 882583 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Passwords detail text color is different in Chrome Settings page.

Project Member Reported by mahmadi@chromium.org, Sep 10

Issue description

Passwords detail text color is different than other cells in Chrome Settings page
 
passwords.png
39.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fe22318a2be8cb2b058bc53f6896477db39a4fc

commit 3fe22318a2be8cb2b058bc53f6896477db39a4fc
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Sep 10 22:21:36 2018

[IOS] Fixes Passwords detail text color in Chrome Settings page

The root cause was that item of type ItemTypeSavedPasswords was not
being properly formatter in |-collectionView:cellForItemAtIndexPath:|

Also sets the detail text of the item at the time of creation, and not
only when the preference changes.

Bug:  882583 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I68a3d8660e520a99ec59b3fc48fb2f78dc59b5fe
Reviewed-on: https://chromium-review.googlesource.com/1217503
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590090}
[modify] https://crrev.com/3fe22318a2be8cb2b058bc53f6896477db39a4fc/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 71.0.3555.0 Canary, iPhone X  iOS 11.4.1, iPhone 7 iOS 12.0 
Looks good
https://drive.google.com/file/d/1Vms4qAjZYFYXre0YDTNTBDeC5gWt6BFG/view

Sign in to add a comment