New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Feature


Sign in to add a comment
link

Issue 882580: Use the passthrough command decoder everywhere

Reported by kbr@chromium.org, Sep 10 Project Member

Issue description

Certain new features like the KHR_parallel_shader_compile extension are being implemented only on the passthrough command decoder. With architectural changes like OOP-D and OOP-R, WebGL is the last major consumer of the GLES2 command decoder, so we can choose to switch to using it everywhere.

This is blocked on shipment of the passthrough command decoder and will have a few more dependencies:

- The ability to use multiple GL bindings in ui/gl. Most of the clients (Skia, etc.) in the GPU process will want to go to the driver directly, but the passthrough command decoder for WebGL will want to go through ANGLE.

- The ability to share textures/images between these sub-components.

This bug will be blocked on other dependent ones.
 

Comment 1 by senorblanco@chromium.org, Sep 14

Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Geoff so it has an owner. Geoff, feel free to reassign.

Comment 2 by geoffl...@chromium.org, Oct 1

Blockedon: 829435

Comment 3 by geoffl...@chromium.org, Oct 4

Blockedon: 892288

Comment 4 by geoffl...@chromium.org, Oct 26

Blockedon: angleproject:2936

Comment 5 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010d075541a62c4979057c2ca972b445e4e597bb

commit 010d075541a62c4979057c2ca972b445e4e597bb
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Oct 26 19:33:01 2018

Don't request ANGLE desktop OpenGL on Android.

BUG=882580

Change-Id: I1a065f608bdd709e74b4bbe83eb744bea5fcc9d2
Reviewed-on: https://chromium-review.googlesource.com/c/1302095
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603172}
[modify] https://crrev.com/010d075541a62c4979057c2ca972b445e4e597bb/ui/gl/gl_surface_egl.cc

Comment 6 by geoffl...@chromium.org, Oct 30

Blockedon: 900228

Comment 7 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/872f6ebdaad666a9fec0cdfd3b089125a192c72c

commit 872f6ebdaad666a9fec0cdfd3b089125a192c72c
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Nov 15 20:01:58 2018

GL: Put commas between vendor and renderer strings.

This allows ANGLE's GL backend's renderer string to be parseable.

BUG=882580

Change-Id: I834dc236b1b72edcbc5285bcca4a1962f95f490d
Reviewed-on: https://chromium-review.googlesource.com/c/1337463
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/872f6ebdaad666a9fec0cdfd3b089125a192c72c/src/libANGLE/renderer/gl/RendererGL.cpp

Comment 8 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c76e302665d63fc20684b4332c07fb538f86b7a

commit 8c76e302665d63fc20684b4332c07fb538f86b7a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 15 23:23:28 2018

Roll src/third_party/angle 666818eacf79..d9ee8bf96207 (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/666818eacf79..d9ee8bf96207


git log 666818eacf79..d9ee8bf96207 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 jmadill@chromium.org Minor inlining optimization to Context draw calls.
2018-11-15 geofflang@chromium.org Allow querying of all draw buffer states on the default framebuffer.
2018-11-15 geofflang@chromium.org GL: Put commas between vendor and renderer strings.
2018-11-15 brandon1.jones@intel.com Autogenerate Repeated Portions of Blit11


Created with:
  gclient setdep -r src/third_party/angle@d9ee8bf96207

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882580
TBR=cwallez@chromium.org

Change-Id: Ic31314f096386f95c4e514df1db56065508acd2c
Reviewed-on: https://chromium-review.googlesource.com/c/1338155
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608572}
[modify] https://crrev.com/8c76e302665d63fc20684b4332c07fb538f86b7a/DEPS

Comment 9 by geoffl...@chromium.org, Nov 19

Blockedon: angleproject:2977

Comment 10 by geoffl...@chromium.org, Nov 19

Blockedon: 906724

Comment 11 by geoffl...@chromium.org, Nov 19

Blockedon: angleproject:2978

Comment 12 by bugdroid1@chromium.org, Nov 26

Project Member

Comment 13 by geoffl...@chromium.org, Nov 26

Blockedon: angleproject:2984

Comment 14 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/256df2cf6f1e614ac3ff86bdb21b06cab6fc7c19

commit 256df2cf6f1e614ac3ff86bdb21b06cab6fc7c19
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Nov 27 02:48:33 2018

Roll src/third_party/angle 15992bef28d8..5552cdf032dd (8 commits)

https://chromium.googlesource.com/angle/angle.git/+log/15992bef28d8..5552cdf032dd


git log 15992bef28d8..5552cdf032dd --date=short --no-merges --format='%ad %ae %s'
2018-11-26 syoussefi@chromium.org Vulkan: Create buffer view for BufferHelper
2018-11-26 geofflang@chromium.org Vulkan: Implement ANGLE_translated_shader_source
2018-11-26 syoussefi@chromium.org Vulkan: Implement vk::BufferView
2018-11-26 jmadill@chromium.org Update clang-format settings.
2018-11-26 geofflang@chromium.org GL: Work around Qualcomm sRGB ReadPixels driver bug.
2018-11-26 geofflang@chromium.org GL: Implement GL_NV_fence on top of GLsync objects.
2018-11-26 matavenrath@nvidia.com Don't generate TypeInfo objects as static objects within GetTypeInfo function
2018-11-26 tobine@google.com Debug: Add Systrace Markers


Created with:
  gclient setdep -r src/third_party/angle@5552cdf032dd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882580
TBR=fjhenigman@chromium.org

Change-Id: Ifb31c9d8ba778ce1fa9528b3981749391828e293
Reviewed-on: https://chromium-review.googlesource.com/c/1351471
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611002}
[modify] https://crrev.com/256df2cf6f1e614ac3ff86bdb21b06cab6fc7c19/DEPS

Comment 15 by geoffl...@chromium.org, Nov 27

Blockedon: 908866

Comment 16 by geoffl...@chromium.org, Nov 27

Blockedon: 908912

Comment 17 by geoffl...@chromium.org, Nov 27

Blockedon: angleproject:2988

Comment 18 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c6a9393fd674171e2f687be766eaf800fadff8c

commit 5c6a9393fd674171e2f687be766eaf800fadff8c
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Dec 04 21:38:16 2018

Run WebGL conformance using ANGLE on Android.

Test that the ANGLE backend flags passed to the browser are used.

BUG=882580

Change-Id: I051859cdedad65d6eb304931644010d8b3bdb5a6
Reviewed-on: https://chromium-review.googlesource.com/c/1299551
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613705}
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/content/test/gpu/gpu_tests/gpu_test_expectations.py
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/gpu/config/software_rendering_list.json
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/testing/buildbot/client.v8.fyi.json
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/5c6a9393fd674171e2f687be766eaf800fadff8c/tools/mb/mb_config.pyl

Comment 19 by kbr@chromium.org, Dec 5

Blockedon: 912161

Comment 20 by kbr@chromium.org, Dec 11

Blockedon: 914053

Comment 21 by kbr@chromium.org, Dec 13

Blockedon: 914631

Comment 22 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20033d2ae4ef5910f2ba087cc76a8a061201b10

commit f20033d2ae4ef5910f2ba087cc76a8a061201b10
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Dec 13 22:15:12 2018

Skip WebGL conformance tests that crash the GPU process on Android.

When the GPU process crashes, the test harness waits for 5 minutes before
marking the test as a timeout.  This causes some shards to have a very long
runtime.

BUG=882580
TBR=kbr@chromium.org

Change-Id: Ib5ef722b3d921b877112491db3bad65131004724
Reviewed-on: https://chromium-review.googlesource.com/c/1376710
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616452}
[modify] https://crrev.com/f20033d2ae4ef5910f2ba087cc76a8a061201b10/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 24 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a7fd19e15c586fed1eef8c7521719fccaae4a7

commit 85a7fd19e15c586fed1eef8c7521719fccaae4a7
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Dec 14 18:31:15 2018

Remove webgl_conformance_gles_passthrough_tests from android-marshmallow-arm64-rel

This test suite is still run on the GPU FYI waterfall and android_angle_rel_ng

BUG=882580

Change-Id: Ifcfb5ff60b7cba84d09358206ab0fd4676a63394
Reviewed-on: https://chromium-review.googlesource.com/c/1378239
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616755}
[modify] https://crrev.com/85a7fd19e15c586fed1eef8c7521719fccaae4a7/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/85a7fd19e15c586fed1eef8c7521719fccaae4a7/testing/buildbot/waterfalls.pyl

Comment 25 by bugdroid, Feb 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10fde88df2ec26914655df12f768a5aa90927730

commit 10fde88df2ec26914655df12f768a5aa90927730
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Feb 14 19:26:37 2019

Remove blackist of oop_rasterization on top of ANGLE.

Now that --enable-passthrough-raster-decoder protects the raster decoder from
being used unepxectedly with ANGLE, we don't need to always disable it through
a blacklist.

BUG=829435
BUG=882580

Change-Id: I0ffc97237810f891d34f0b15835aa60efde85247
Reviewed-on: https://chromium-review.googlesource.com/c/1464110
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632317}
[modify] https://crrev.com/10fde88df2ec26914655df12f768a5aa90927730/gpu/config/software_rendering_list.json

Sign in to add a comment