New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 813829



Sign in to add a comment

chromite: Add dynamic partition reading from a given cros image

Project Member Reported by chingcodes@chromium.org, Sep 10

Issue description

From conversation with Vapier:
> as a strawman, we could have a chromite.lib.cgpt module with a Disk class that could be instantiated from a disk image, and then the Disk class would have some methods like GetPartitionDetails(label) which would return a namedtuple with the fields that make sense (start, size, part number, label, type, uuid, flags, etc...).  maybe even provide a few helpers on top of it like GetPartitionNumber(label) which would return GetPartitionDetails(label).partno.

Similar issue:
b/35045101
 
Blocking: 813829
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d022b13c47ca8b0fcd2ad9c68a389cc4ca1b0e8c

commit d022b13c47ca8b0fcd2ad9c68a389cc4ca1b0e8c
Author: Chris Ching <chingcodes@google.com>
Date: Fri Sep 14 19:08:27 2018

cgpt: Add ability to get partition information from a CrOS image

For use in leu of hardcoded partition numbers

BUG= chromium:882559 
TEST=./cgpt_unittest

Change-Id: I93f0c53033a44eee5a74bd1a7f55b481d1716d2c
Reviewed-on: https://chromium-review.googlesource.com/1217484
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/d022b13c47ca8b0fcd2ad9c68a389cc4ca1b0e8c/lib/cgpt_unittest.py
[add] https://crrev.com/d022b13c47ca8b0fcd2ad9c68a389cc4ca1b0e8c/lib/cgpt.py
[add] https://crrev.com/d022b13c47ca8b0fcd2ad9c68a389cc4ca1b0e8c/lib/cgpt_unittest

Status: Fixed (was: Assigned)

Sign in to add a comment