New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882533 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Clean up Chrome Reporting Extension policy strings

Project Member Reported by nicolaso@chromium.org, Sep 10

Issue description

"This policy is only effective when the Chrome Reporting Extension and Cloud Management are enabled."

We should change 'Cloud Management' to something concrete, e.g. point to a policy that allows admins to enroll devices for cloud management.

This will make these strings easier to translate.

We should try to merge this into M70.

See b/114687474
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa02a81570615aebe16b887fe035e4bff5a72227

commit fa02a81570615aebe16b887fe035e4bff5a72227
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Tue Sep 11 14:29:25 2018

Clean up Chrome Reporting Extension policy strings

Bug:  882533 
Change-Id: I84f2d5a88f42d896b218e37c310da3f606b3578c
Reviewed-on: https://chromium-review.googlesource.com/1216811
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590299}
[modify] https://crrev.com/fa02a81570615aebe16b887fe035e4bff5a72227/components/policy/resources/policy_templates.json

Labels: Merge-Request-70 OS-Chrome OS-Linux OS-Mac OS-Windows
Requesting a merge for M70, since that's when the original string was introduced.
Labels: -Merge-Request-70 Merge-Approved-70
Approving merge to M70 branch:3538
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cacb2fd84301e2a6068e53e4784ce8a4ddfe8c1

commit 0cacb2fd84301e2a6068e53e4784ce8a4ddfe8c1
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Sep 12 18:58:33 2018

Merge into M70: Clean up Chrome Reporting Extension policy strings

Bug:  882533 
Change-Id: I84f2d5a88f42d896b218e37c310da3f606b3578c
Reviewed-on: https://chromium-review.googlesource.com/1216811
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590299}(cherry picked from commit fa02a81570615aebe16b887fe035e4bff5a72227)
Reviewed-on: https://chromium-review.googlesource.com/1222587
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#338}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/0cacb2fd84301e2a6068e53e4784ce8a4ddfe8c1/components/policy/resources/policy_templates.json

Status: Fixed (was: Untriaged)
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 10 with chrome #70.0.3538.22

Steps Followed:
===============
1. Load chrome.adm file in gpedit.msc
2. Goto Computer Configuration -> Administrative Templates -> Classic Administrative Template -> Google -> Google Chrome -> Chrome Reporting Extension.
3. Seen 4 policies
   1. Report OS and Google Chrome Version Information
   2. Report Google Chrome Policy Information
   3. Report Machine Identification information
   4. Report User Identification information

Observations:
==============
As per https://b.corp.google.com/issues/114687474#comment7, in above 4 policies didn't see any string as "This policy is only effective when the Chrome Reporting Extension is enabled, and the machine is enrolled with MachineLevelUserCloudPolicyEnrollmentToken" 

Attaching the screen-cast for reference.

nicolaso@ Could you please look into it and let us know your observations.
882533.mp4
5.2 MB View Download
Status: Assigned (was: Fixed)
Hi Nicolas,

On Chrome OS I see these policies in chrome://policy page, however they have "Unknown policy" errors (see attached screenshot).

Could you please take a look at it?

Chrome OS: 11021.23.0
Chrome: 70.0.3538.28
Device: Santa
Screenshot 2018-09-21 at 3.41.19 PM.png
129 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d1f66b5c661edcb60cba7175c4aa5fad328609

commit 98d1f66b5c661edcb60cba7175c4aa5fad328609
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Sep 24 18:59:08 2018

[Enterprise Reporting] Remove 'enterprise default' policy values

The policies don't exist on ChromeOS, and the 'enterprise default' only
applies to ChromeOS. This caused policies to get set, and appear in
`about:policy`, even though they were not supported on that platform.

Bug:  882533 
Change-Id: Ibc17dc4254812fb39048d97ea4b6e45dae7f4380
Reviewed-on: https://chromium-review.googlesource.com/1240494
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593617}
[modify] https://crrev.com/98d1f66b5c661edcb60cba7175c4aa5fad328609/components/policy/resources/policy_templates.json

Labels: Merge-Request-70
Requesting another merge into M70 for the latest patch.
let's verify this in canary first. 
how does it look?
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 25

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Verified fixed on M-71 (Chrome OS), policies are not present in chrome://policy page (see attached screenshot).

Chrome OS: 11102.0.0
Chrome: 71.0.3562.0
Device: Whitetip
Screenshot 2018-09-27 at 9.15.34 AM.png
276 KB View Download
abulsyed@, it looks like my patch fixed the issue. Can we merge it into M70?
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 1

Cc: abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 1

Labels: -merge-approved-70
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda1146a2842b8e71836c6ceb2eef7b00535d3cc

commit eda1146a2842b8e71836c6ceb2eef7b00535d3cc
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Oct 01 17:07:24 2018

[Enterprise Reporting] Merge into M70: Remove 'enterprise default' policy values

The policies don't exist on ChromeOS, and the 'enterprise default' only
applies to ChromeOS. This caused policies to get set, and appear in
`about:policy`, even though they were not supported on that platform.

Tbr: pastarmovj
Bug:  882533 
Change-Id: Ibc17dc4254812fb39048d97ea4b6e45dae7f4380
Reviewed-on: https://chromium-review.googlesource.com/1240494
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593617}(cherry picked from commit 98d1f66b5c661edcb60cba7175c4aa5fad328609)
Reviewed-on: https://chromium-review.googlesource.com/1254755
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#776}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/eda1146a2842b8e71836c6ceb2eef7b00535d3cc/components/policy/resources/policy_templates.json

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/eda1146a2842b8e71836c6ceb2eef7b00535d3cc

Commit: eda1146a2842b8e71836c6ceb2eef7b00535d3cc
Author: nicolaso@chromium.org
Commiter: zmin@chromium.org
Date: 2018-10-01 17:07:24 +0000 UTC

[Enterprise Reporting] Merge into M70: Remove 'enterprise default' policy values

The policies don't exist on ChromeOS, and the 'enterprise default' only
applies to ChromeOS. This caused policies to get set, and appear in
`about:policy`, even though they were not supported on that platform.

Tbr: pastarmovj
Bug:  882533 
Change-Id: Ibc17dc4254812fb39048d97ea4b6e45dae7f4380
Reviewed-on: https://chromium-review.googlesource.com/1240494
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593617}(cherry picked from commit 98d1f66b5c661edcb60cba7175c4aa5fad328609)
Reviewed-on: https://chromium-review.googlesource.com/1254755
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#776}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
nicolaso@ Could you please help us with repro steps to verify the fix from TE End.
kkaluri@: it looks like this issue contains 2 bugs related to this set of policies:

(1) Incorrect description about Cloud Management.

For this one, we can check the various artifacts to make sure they don't say 'Cloud Management' near the end:

  This policy is only effective when the Chrome Reporting Extension is enabled, and the machine is enrolled with MachineLevelUserCloudPolicyEnrollmentToken.

I'm not super familiar with the Chrome release process, but I suspect there was a string freeze for translators at some point, and the string changes weren't picked up for M70. Since it's not critical to fix the string, it will probably be a `WontFix' for M70.

There are multiple artifacts that include the string, e.g.:

1. For M70/71: in the Chrome Enterprise Bundle, verify ADM/ADMX files like kkaluri@ did earlier in this thread. Or, look in `Documentation/Chrome Policies/en-US/'.

2. For M71: Look at the Policy List on the wiki [1]. At the time of writing this, the wiki hasn't updated with my patch yet. The patch landed in 71.0.3550.0, and the wiki was generated in 71.0.3546.0.

(2) On ChromeOS, the policy appears in `about:policy' even when not managed, reported by ibezmenov@.

This one should be fixed in M70.

Unless ibezmenov@ has some more specific steps to repro, simply go to `about:policy' and see if any unknown `Report...Data' policies show up, on ChromeOS.

[1] https://www.chromium.org/administrators/policy-list-3#ReportVersionData
Status: Fixed (was: Assigned)
Labels: cros-verified
Verified on Chrome OS in M70 (11021.100.0, 70.0.3538.124) and M72 (11316.14.0, 72.0.3626.12) as well. For M71 verification see c#13.

Sign in to add a comment