New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882526 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 25
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Test autotest_lib.site_utils.lxc.container_pool.pool_unittest.ThrottleTests flake

Project Member Reported by lannm@google.com, Sep 10

Issue description

betty-paladin failed: https://luci-milo.appspot.com/buildbot/chromeos/betty-paladin/3846

The CQ CLs don't appear to be related, and there seems to be a history of flake in this suite:  crbug.com/833478 

 
Labels: Hotlist-Deputy
Labels: -Hotlist-Deputy
Owner: jkop@chromium.org
Status: Assigned (was: Untriaged)
jkop, is this close to your container work?
Not anything I've touched any time recently. Also most of the code I touched got turned off.
I'm unclear on how much non-pool-specific code (i.e. live code) is relying on tests under autotest_lib.site_utils.lxc.* unittests in general; kenobi@ did a bunch of refactoring to enable the container pool and all the results of that refactoring live under autotest_lib.site_utils.lxc. But I'm confident that the pool itself is dead code, so deleting autotest_lib.site_utils.lxc.container_pool.* should be safe.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f0abda1c431ba478b4cee2b1a72fa7b1c068e967

commit f0abda1c431ba478b4cee2b1a72fa7b1c068e967
Author: Jacob Kopczynski <jkop@google.com>
Date: Tue Sep 18 21:03:57 2018

Remove all lxc/container_pool code

This is believed all dead and has been flaky.

BUG= chromium:882526 
TEST=Run all other unit tests

Change-Id: I603972e826e2bc0d9b636a9e644c6318f444ac72
Reviewed-on: https://chromium-review.googlesource.com/1217491
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/__init__.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/pool_unittest.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/common.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/pool.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/unittest_client.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/message.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/service.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/async_listener.py
[modify] https://crrev.com/f0abda1c431ba478b4cee2b1a72fa7b1c068e967/site_utils/lxc/container_bucket.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/client_unittest.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/async_listener_unittest.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc_pool_service.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/client.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/error.py
[delete] https://crrev.com/c4374694b2a3353125c08fc5008458599df57ac8/site_utils/lxc/container_pool/service_unittest.py

Status: Fixed (was: Assigned)
Test (and the code it tested) removed, and nothing broke

Sign in to add a comment