New issue
Advanced search Search tips

Issue 882520 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 914423



Sign in to add a comment

BrowserSwitcher doesn't expand environment variables

Project Member Reported by nicolaso@chromium.org, Sep 10

Issue description

Labels: BrowserSwitcher
Labels: -Pri-3 Pri-2
I would even allow myself to claim it's a P2 from the perseptive of the project :)
Components: Enterprise>BrowserSwitcher
Labels: -BrowserSwitcher
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b840a9c1e16e0fe278b9517af4e6b5f8365d176

commit 4b840a9c1e16e0fe278b9517af4e6b5f8365d176
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Tue Sep 18 14:46:52 2018

[BrowserSwitcher] Expand env-vars in command-line

Environment variables on the command-line (alternative browser path and
parameters) are expanded before being passed to the external program.

On Windows, this means strings like '%HOME%' are expanded.

On Linux, this means strings like '$VAR' and '${VAR}' are expanded. Also, a '~'
at the beginning of a command-line argument is expanded to the HOME environment
variable.

Bug:  882520 
Change-Id: I9822b465999b3515d37e882f18a19df39b3e64d6
Reviewed-on: https://chromium-review.googlesource.com/1225854
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592036}
[modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_linux.cc
[modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc
[modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_win.cc
[modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/chrome_content_browser_client.cc

Status: Verified (was: Untriaged)

Sign in to add a comment