BrowserSwitcher doesn't expand environment variables |
||||
Issue descriptionBrowserSwitcher doesn't expand env-vars [1], but the LBS extension does [2]. We should expand them to improve backwards compatibility. [1] https://cs.chromium.org/chromium/src/chrome/browser/browser_switcher/alternative_browser_driver.cc?l=79&rcl=1883bad43889c9f0a5d7f6ca3dabff648c73bb90 [2] https://github.com/LegacyBrowserSupport/legacy-browser-support/blob/8caa623692b94dc0154074ce904de8f60ee8a404/core/browser_switcher_core.cc#L834
,
Sep 11
I would even allow myself to claim it's a P2 from the perseptive of the project :)
,
Sep 11
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b840a9c1e16e0fe278b9517af4e6b5f8365d176 commit 4b840a9c1e16e0fe278b9517af4e6b5f8365d176 Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Date: Tue Sep 18 14:46:52 2018 [BrowserSwitcher] Expand env-vars in command-line Environment variables on the command-line (alternative browser path and parameters) are expanded before being passed to the external program. On Windows, this means strings like '%HOME%' are expanded. On Linux, this means strings like '$VAR' and '${VAR}' are expanded. Also, a '~' at the beginning of a command-line argument is expanded to the HOME environment variable. Bug: 882520 Change-Id: I9822b465999b3515d37e882f18a19df39b3e64d6 Reviewed-on: https://chromium-review.googlesource.com/1225854 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592036} [modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_linux.cc [modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc [modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/browser_switcher/alternative_browser_driver_win.cc [modify] https://crrev.com/4b840a9c1e16e0fe278b9517af4e6b5f8365d176/chrome/browser/chrome_content_browser_client.cc
,
Sep 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nicolaso@chromium.org
, Sep 10