New issue
Advanced search Search tips

Issue 882519 link

Starred by 1 user
Status: Fixed
Owner:
sgilhuly@chromium.org
Closed: Sep 20
Cc:
danakj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 732805



Sign in to add a comment

Fix HostContextFactoryPrivate after GPU process restart

Project Member Reported by kylec...@chromium.org, Sep 10 
This function doesn't quite work correctly. It's called to early and doesn't persist past the information past GPU process crashes. The following changes are needed:

1. Store |output_is_secure| in HostContextFactoryPrivate::CompositorData if there is a corresponding CompositorData in |compositor_data_map_|. On CompositorData construction |output_is_secure| should default to false.
2. In HostContextFactoryPrivate::ConfigureCompositor() call SetOutputIsSecure() with the stored value on the DisplayPrivatePtr. This should happen right after Resize() is called on DisplayPrivatePtr.

Comment 1 by kylec...@chromium.org, Sep 13

Summary: Fix HostContextFactoryPrivate after GPU process restart (was: Fix HostContextFactoryPrivate::SetOutputIsSecure())
I think we also need to cache |interval| from SetAuthoritativeVSyncInterval() in the same way. 

SetDisplayColorSpace(), SetDisplayColorMatrix() and SetVisible() are all called by ui::Compositor when a new LayerTreeFrameSink is created so those don't need to be cached.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83526f9aef2fd6095c0f6bbab50438895323c22c

commit 83526f9aef2fd6095c0f6bbab50438895323c22c
Author: Sean Gilhuly <sgilhuly@chromium.org>
Date: Thu Sep 20 14:22:58 2018

Persist calls to HostContextFactoryPrivate::SetOutputIsSecure

Remember the last call to SetOutputIsSecure, and apply the information
when the compositor is configured, or if the gpu process crashes.

Bug:  882519 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id212aaae3b2c164575c1d8e92e93e623bd182d69
Reviewed-on: https://chromium-review.googlesource.com/1225290
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592789}
[modify] https://crrev.com/83526f9aef2fd6095c0f6bbab50438895323c22c/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/83526f9aef2fd6095c0f6bbab50438895323c22c/services/ws/host_context_factory.cc
[modify] https://crrev.com/83526f9aef2fd6095c0f6bbab50438895323c22c/ui/compositor/host/host_context_factory_private.cc
[modify] https://crrev.com/83526f9aef2fd6095c0f6bbab50438895323c22c/ui/compositor/host/host_context_factory_private.h

Comment 3 by sgilhuly@chromium.org, Sep 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment