New issue
Advanced search Search tips

Issue 882497 link

Starred by 4 users
Status: Duplicate
Merged: issue 882212
Owner: ----
Closed: Sep 10
Cc:
pkasting@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Changing "background_tab" under "colors" changes drag handle height.

Reported by kohltast...@gmail.com, Sep 10 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Install a theme that changes "background_tab" under "colors".
2. Notice change in drag handle height.

What is the expected behavior?
Changing a color should not modify anything other than color.

What went wrong?
Color was changed, no images used, drag handle height changed because of the color.

WebStore page: 

Did this work before? N/A 

Chrome version: 69.0.3497.81  Channel: stable
OS Version: 10.0
Flash Version: 

There is no reason why a changing a color should change the size of anything. If it's too hard to fix, I could swap to Firefox which doesn't have the issue.
chrome_2018-09-10_03-50-29.png
2.9 KB View Download

Comment 1 by kohltast...@gmail.com, Sep 10 

I was told before in a similar issue that it had to do with background tab shapes. However the theme I'm currently using only changes color, no shapes or images.

Please don't mark this as a duplicate, I don't see why a color change would warrant any type of size change.

Comment 2 by meh...@chromium.org, Sep 10

Cc: pkasting@chromium.org
Components: UI>Browser>TabStrip
As far as I understood in  issue 882212  c#7 is, that without using tab shapes for background tabs, you can start dragging the window already a few pixels underneath the top border of the "invisible" background tab. This is apparently not possible with background tabs using tab shapes. In order not to lose the dragging height when using themes with tab shapes on background tabs, it is necessary to increase the height of the drag zone by a few pixels.

Attached are two screencast showing the difference. It is on Mac, but you can see the difference when you zoom in.

1. Screencast without tab shapes
2. Screencast with tab shapes
without_tab_shape.mov
823 KB View Download
with_tab_shape.mov
785 KB View Download

Comment 3 by kohltast...@gmail.com, Sep 10 

Thank you for clarifying the issue, I was bit a confused before on what he meant by background tab shapes. I understand how to get around this issue now. :-)

Comment 4 by meh...@chromium.org, Sep 10 

You are welcome :) Do you agree with merging this issue as a dupe of  issue 882212  :)

Comment 5 by kohltast...@gmail.com, Sep 10 

Go right ahead, I was just a bit confused at the original explanation.
Thank you again for the time you spent helping me understand. :)

Comment 6 by meh...@chromium.org, Sep 10

Mergedinto: 882212
Status: Duplicate (was: Unconfirmed)
No problems - happy to help :)
►

Sign in to add a comment