New issue
Advanced search Search tips

Issue 882488 link

Starred by 2 users
Status: Fixed
Owner:
seanmccullough@chromium.org
Closed: Oct 2
Cc:
jbudorick@chromium.org
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 815006



Sign in to add a comment

Push new version of SoM to pick up experimental test suite handling fix

Project Member Reported by ojan@chromium.org, Sep 10 
Sheriff-o-matic says this has been failing for 8 builds, but I don’t see any failures in the ci page. Turns out the bot is green because it correctly identifies this test suite as experimental and ignores the failure. Obviously sheriff-o-matic should do the same.

Sheriff-o-matic failure text: Builder interactive_ui_tests (experimental) on Windows-10-15063 failing on chromium.win/Win10 Tests x64 (dbg)

Link: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29

Comment 1 by ojan@chromium.org, Sep 10 

Also
 - webkit_layout_tests (experimental) failing on chromium.win/Win7 Tests (dbg)(1)
 - telemetry_unittests (experimental) on Windows-10-15063 failing on chromium.win/Win10 Tests x64 (dbg)

Comment 2 by ojan@chromium.org, Sep 11 

FWIW, this is making sheriffing *much* harder with a ton of noise. If there's any way to fix this soon, I think it would be much appreciated.

Comment 3 by shend@chromium.org, Sep 14

Status: Untriaged (was: Unconfirmed)
Yeah this is weird, it's now showing as 41 out of the last 41 builds have failed for me. But when I go to the bot, it's definitely not a 100% failure.

Comment 4 by seanmccullough@chromium.org, Sep 14

Cc: jbudorick@chromium.org
Is this related to https://bugs.chromium.org/p/chromium/issues/detail?id=815006 ? jbudorick@ added some support to the gatekeeper config parser so it *should* ignore "experimental_tests" categories.

Comment 5 by jbudorick@chromium.org, Sep 21

Owner: seanmccullough@chromium.org
Status: Assigned (was: Untriaged)
it is, and I landed https://chromium.googlesource.com/infra/infra/+/4d90c8b790a3ea712967e5462d7b85793b1fdb95 to fix it on august 27. SoM was last deployed on august 10, though.

Comment 6 by jbudorick@chromium.org, Sep 21

Blocking: 815006
Summary: Push new version of SoM to pick up experimental test suite handling fix (was: experimental test suites are green on buildbot and red in sheriff-o-matic)
Updating bug title to reflect what's left.

Comment 7 by seanmccullough@google.com, Sep 21 

just did a push to staging: https://sheriff-o-matic-staging.appspot.com/chromium

if that looks ok we can push to prod tomorrow.

Comment 8 by jbudorick@chromium.org, Oct 2

Status: Fixed (was: Assigned)
This happened on 2018-09-28.
►

Sign in to add a comment