📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/153065e3640000

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1005939b640000

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/153065e3640000

Deadline exceeded while waiting for HTTP response from URL: https://chromium.googlesource.com/chromium/src/+log/8943110d03e7b0b3eb1f8ab471f8fa27bb2bd3d5..8c08472ba89c88093f5ff2ab4ebc6b0191026226?format=JSON

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1005939b640000

[PartitionAlloc] Add a flag to allow callers to zero-fill allocations. by palmer@chromium.org
https://chromium.googlesource.com/chromium/src/+/7bd9d693667d585c44d2d29666860c678c19bc83
542.6 → 598.3 (+55.62)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

Also applies to legacy layout. blink_perf.layout/subtree-detaching and the flexbox tests all show between a 5% and 10% regression.

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/108fc5bb640000

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/13b2e6b5640000

https://chromeperf.appspot.com/report?sid=d2c469578ae45e18eb750b140e999a9a7eeb84de3a2cef05f04a6a3698068618

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/108fc5bb640000

[PartitionAlloc] Add a flag to allow callers to zero-fill allocations. by palmer@chromium.org
https://chromium.googlesource.com/chromium/src/+/7bd9d693667d585c44d2d29666860c678c19bc83
353.9 → 374.3 (+20.42)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1494dffd640000

Running Pinpoint job: https://pinpoint-dot-chromeperf.appspot.com/job/1494dffd640000

https://chromium-review.googlesource.com/c/chromium/src/+/1220468

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1494dffd640000

[PartitionAlloc] Don't poison memory on free. by palmer@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1220468/2
369 → 348.8 (-20.22)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99391f020f67be766ae8203c4563510b19916494

commit 99391f020f67be766ae8203c4563510b19916494
Author: Chris Palmer <palmer@chromium.org>
Date: Tue Sep 11 22:38:05 2018

[PartitionAlloc] Don't poison memory on free.

It might? be the cause of a perf regression.

Bug:  882471 , 680657 
Change-Id: Iec34a348426ccfdf5864a3b2cbe0c377da20ac0e
Reviewed-on: https://chromium-review.googlesource.com/1220468
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590508}
[modify] https://crrev.com/99391f020f67be766ae8203c4563510b19916494/base/allocator/partition_allocator/partition_page.h

Thanks for the quick turnaround palmer!

Oops, a minor mishap. Reverting but I'll repair it tomorrow.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b006ff1e72e73263ef4e462a1e7324327e864ee

commit 7b006ff1e72e73263ef4e462a1e7324327e864ee
Author: Chris Palmer <palmer@chromium.org>
Date: Wed Sep 12 00:18:56 2018

Revert "[PartitionAlloc] Don't poison memory on free."

This reverts commit 99391f020f67be766ae8203c4563510b19916494.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [PartitionAlloc] Don't poison memory on free.
> 
> It might? be the cause of a perf regression.
> 
> Bug:  882471 , 680657 
> Change-Id: Iec34a348426ccfdf5864a3b2cbe0c377da20ac0e
> Reviewed-on: https://chromium-review.googlesource.com/1220468
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590508}

TBR=palmer@chromium.org,eae@chromium.org,haraken@chromium.org

Change-Id: I6c687b8cb2b8aa0bc3de682c1c39f430b1f6b05c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  882471 ,  680657 
Reviewed-on: https://chromium-review.googlesource.com/1220815
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590545}
[modify] https://crrev.com/7b006ff1e72e73263ef4e462a1e7324327e864ee/base/allocator/partition_allocator/partition_page.h

Why the revert...?

 Issue 883144  has been merged into this issue.

#21: See #22. :)

 Issue 883170  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9

commit a027d75bf6661b126d95a5032ea45c6ad2a6d0a9
Author: Chris Palmer <palmer@chromium.org>
Date: Wed Sep 12 20:15:26 2018

[PartitionAlloc] Don't poison memory on free.

It seems to have been the cause of a perf regression.

This is a re-land of
https://chromium-review.googlesource.com/c/chromium/src/+/1220468, with a fixed
test: the code and unit tests need to have matching behavior and expectations
when `DCHECK_IS_ON()`.

Bug:  882471 , 680657 , 883144 
Change-Id: I7afb7c8d9f57431dfd4e264a6a22711660e040d6
Reviewed-on: https://chromium-review.googlesource.com/1222290
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590800}
[modify] https://crrev.com/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9/base/allocator/partition_allocator/partition_alloc_unittest.cc
[modify] https://crrev.com/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9/base/allocator/partition_allocator/partition_page.h

Issue 883467 has been merged into this issue.

 Issue 883386  has been merged into this issue.