New issue
Advanced search Search tips

Issue 882458 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe is flakey on Win

Project Member Reported by wjmaclean@chromium.org, Sep 10

Issue description

OS: Win


 
This is a rather strange flke, in that:

1) If it occurs on the initial running of the test, all re-tries will also fail.
2) The identical test, run in HighDPI mode, never seems to flake.
3) The test fails because it thinks a cursor has already be registered on the root view, which *could* occur via a spurious mousemove/enter over the root view, but we (thought) we had these stomped out in a previous CL (https://chromium-review.googlesource.com/c/chromium/src/+/1194253).


Listed below are a couple of failure logs.

Failure#1
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2994
https://chromium-swarm.appspot.com/task?id=3fd1acdca9dcba10&refresh=10&show_raw=1

Failing at line 2956: https://cs.chromium.org/chromium/src/content/browser/site_per_process_hit_test_browsertest.cc?rcl=18b8d9c41b917c7b6a44a67d7e927db10b7ee919&l=2956

Failure #2

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/83430
https://chromium-swarm.appspot.com/task?id=3fd2a161947adc10&refresh=10&show_raw=1


Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74a0575168540be713c147040e6f870edd9a5c24

commit 74a0575168540be713c147040e6f870edd9a5c24
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Sep 10 16:05:43 2018

Disable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe on Win.

Temporarily disable this test while we resolve the flakiness issue.

Bug: 882458
Change-Id: I03dcfd61ec172fc8206414428427d8439f503bff
TBR: kenrb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1216704
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589932}
[modify] https://crrev.com/74a0575168540be713c147040e6f870edd9a5c24/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/796ffe34ca4ddf546e8cb0c2b573301d65ce4ef3

commit 796ffe34ca4ddf546e8cb0c2b573301d65ce4ef3
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 14 20:53:27 2018

Diagnostic for issue 882458.

This is a CL with temporary diagnostic code for
https://crbug.com/882458.

This CL will be landed and left in ToT long enough to collect data, and
then reverted quickly, and certainly prior to the next stable branch
cut.

Bug: 882458
Change-Id: I5c5d1f2e26a032f743a86af6f335e6942f97e423
Reviewed-on: https://chromium-review.googlesource.com/1227130
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591468}
[modify] https://crrev.com/796ffe34ca4ddf546e8cb0c2b573301d65ce4ef3/content/browser/renderer_host/cursor_manager.cc
[modify] https://crrev.com/796ffe34ca4ddf546e8cb0c2b573301d65ce4ef3/content/browser/renderer_host/cursor_manager.h
[modify] https://crrev.com/796ffe34ca4ddf546e8cb0c2b573301d65ce4ef3/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5a4c0143dba99ca0a9e8eba54187c7f8d7e7dc

commit 3a5a4c0143dba99ca0a9e8eba54187c7f8d7e7dc
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 14 21:40:52 2018

Temporarily re-enable CursorUpdateReceivedFromCrossSiteIframe.

Re-enabling this test just long enough to collect logs from a couple
of flakey runs of the test.

TBR=kenrb@chromium.org

Bug: 882458
Change-Id: Icb727a91a0b4178cf4cf18a162d218c78f47371f
Reviewed-on: https://chromium-review.googlesource.com/1227306
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591485}
[modify] https://crrev.com/3a5a4c0143dba99ca0a9e8eba54187c7f8d7e7dc/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa5a3d5052abb4af070109594c6bc85255f953b

commit 0fa5a3d5052abb4af070109594c6bc85255f953b
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Sat Sep 15 12:25:17 2018

Add diagnostic output.

Add diagnostic output to assist with discovering cause of flake.

TBR=kenrb@chromium.org

Bug: 882458
Change-Id: I6bf7e36770a4d95b2d25520c8407460360583028
Reviewed-on: https://chromium-review.googlesource.com/1227671
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591584}
[modify] https://crrev.com/0fa5a3d5052abb4af070109594c6bc85255f953b/content/browser/site_per_process_hit_test_browsertest.cc

Cc: wjmaclean@chromium.org
 Issue 884438  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c09a2e74b06599360b3136387906d9aeb8e791

commit 43c09a2e74b06599360b3136387906d9aeb8e791
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Sep 17 15:50:16 2018

Block all system events in SitePerProcessHitTestBrowserTests.

As part of an effort to fix the associated bug, this CLs will block all
system level events that might possible interfere with a
SitePerProcessHitTestBrowserTest.

Bug: 882458
Change-Id: I480cdcb7c55ec068efc2fda13b1d6a3d459db329
Reviewed-on: https://chromium-review.googlesource.com/1228293
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591690}
[modify] https://crrev.com/43c09a2e74b06599360b3136387906d9aeb8e791/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2affd10c4a40bc6c5d34edfcf3dc0a9cc91eba74

commit 2affd10c4a40bc6c5d34edfcf3dc0a9cc91eba74
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 18 00:16:54 2018

Tentatively re-enable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe.

This CL tests if
https://chromium-review.googlesource.com/c/chromium/src/+/1228293
has any effect on the flakiness of this test.

Bug: 882458
Change-Id: I0bd0503bd223fd4694f9e106882fcd68efeda85d
Reviewed-on: https://chromium-review.googlesource.com/1228513
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591892}
[modify] https://crrev.com/2affd10c4a40bc6c5d34edfcf3dc0a9cc91eba74/content/browser/site_per_process_hit_test_browsertest.cc

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5DdXJzb3JVcGRhdGVSZWNlaXZlZEZyb21Dcm9zc1NpdGVJZnJhbWUvMQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3832746f7b9a34125b87f1b21e43038c6780c10

commit a3832746f7b9a34125b87f1b21e43038c6780c10
Author: James MacLean <wjmaclean@chromium.org>
Date: Tue Sep 18 11:56:49 2018

Revert "Tentatively re-enable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe."

This reverts commit 2affd10c4a40bc6c5d34edfcf3dc0a9cc91eba74.

Reason for revert: The test is continuing to flake, so turning it off again on Win.

Original change's description:
> Tentatively re-enable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe.
> 
> This CL tests if
> https://chromium-review.googlesource.com/c/chromium/src/+/1228293
> has any effect on the flakiness of this test.
> 
> Bug: 882458
> Change-Id: I0bd0503bd223fd4694f9e106882fcd68efeda85d
> Reviewed-on: https://chromium-review.googlesource.com/1228513
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591892}

TBR=kenrb@chromium.org,wjmaclean@chromium.org

Change-Id: I651fb628162ec2bf301782d5cc61ad4af043fde4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882458
Reviewed-on: https://chromium-review.googlesource.com/1230433
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592002}
[modify] https://crrev.com/a3832746f7b9a34125b87f1b21e43038c6780c10/content/browser/site_per_process_hit_test_browsertest.cc

Cc: pnangunoori@chromium.org
Just to update:

SitePerProcessHitTestBrowserTest.ScrolledNestedPopupMenuTest/2-failed on Win64 Stable on official desktop continuous

Link to the builder:
------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20stable/builds/1182

Error log:
---------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_stable%2F1182%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout

wjmaclean@, Please take a look into it.

Thanks..!
pnangunoori@chromium.org - for new test failures, please file a new bug. These two issues are unrelated.

I have filed https://bugs.chromium.org/p/chromium/issues/detail?id=889002 for this issue.
Labels: -Sheriff-Chromium
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c3fa99908f39b770a5d2cf3f95abbc70313372

commit 25c3fa99908f39b770a5d2cf3f95abbc70313372
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Oct 18 10:10:25 2018

Disable CursorUpdateReceivedFromCrossSiteIframe on Windows

The HiDPI version of the test is flaky on windows bots as well.

TBR: kenrb@chromium.org
Bug: 896609, 882458
Change-Id: Ifc8fdb8f33ce319398566b22737fcfe7f8f3d972
Reviewed-on: https://chromium-review.googlesource.com/c/1288532
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600714}
[modify] https://crrev.com/25c3fa99908f39b770a5d2cf3f95abbc70313372/content/browser/site_per_process_hit_test_browsertest.cc

Cc: chanli@chromium.org
 Issue 895557  has been merged into this issue.
Re #13: ScrolledNestedPopupMenuTest is https://bugs.chromium.org/p/chromium/issues/detail?id=889002
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3dedf2487da89dbdf3715573925c14a8142ce81

commit e3dedf2487da89dbdf3715573925c14a8142ce81
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Wed Jan 09 20:26:31 2019

Retry enabling a flaky windows test

After adding a flag to ignore os input as part of
https://chromium-review.googlesource.com/c/chromium/src/+/1377727
let's do another try to see whether this test
works fine or not.

Bug: 882458
Change-Id: I62f42ef98a8ec76a760b8cf51c31da2fb320922d
Reviewed-on: https://chromium-review.googlesource.com/c/1403063
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621289}
[modify] https://crrev.com/e3dedf2487da89dbdf3715573925c14a8142ce81/content/browser/site_per_process_hit_test_browsertest.cc

Sign in to add a comment