New issue
Advanced search Search tips

Issue 882454 link

Starred by 1 user
Status: Fixed
Owner:
derat@chromium.org
Closed: Sep 24
Cc:
bpastene@chromium.org
achuith@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make local_test_runner read tast_use_flags.txt when executed manually

Project Member Reported by derat@chromium.org, Sep 10 
vm_sanity.py runs non-informational, Chrome-exercising Tast tests by executing local_test_runner directly. As discussed in  issue 876587 , vm_sanity.py currently uses an attribute expression that excludes dep:android in order to skip Android tests (which aren't supported in this VM).

I could probably make local_tast_runner read the DUT's list of software features from /usr/local/etc/tast_use_flags.txt when it's executed directly (instead of via the tast process). Then Android tests (and any other tests that depend on software features unsupported by the VM) could then be skipped automatically.

(I didn't realize that local execution of local_tast_runner would be used for anything besides debugging, so it doesn't have the best user experience right now.) :-)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/f34aa39b6d365148e6f216b7815e9b4fbfdd9c37

commit f34aa39b6d365148e6f216b7815e9b4fbfdd9c37
Author: Daniel Erat <derat@chromium.org>
Date: Sun Sep 16 03:58:19 2018

tast: Make runner check software features when run manually.

Make local_test_runner determine the DUT's available
software features when it's executed directly and passed an
attribute expression (rather than a list of specific tests).
This allows unsupported tests to be skipped automatically in
vm_sanity.py.

BUG= chromium:882454 
TEST=added unit test; also verified that unsupported tests
     are skipped when invoking local_test_runner with an
     attribute expression

Change-Id: I9f2c6fed2f9564de4044c34f71d0707e154611ac
Reviewed-on: https://chromium-review.googlesource.com/1227513
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/f34aa39b6d365148e6f216b7815e9b4fbfdd9c37/src/chromiumos/tast/runner/runner_test.go
[modify] https://crrev.com/f34aa39b6d365148e6f216b7815e9b4fbfdd9c37/src/chromiumos/tast/runner/args.go
[modify] https://crrev.com/f34aa39b6d365148e6f216b7815e9b4fbfdd9c37/src/chromiumos/tast/runner/runner.go
[modify] https://crrev.com/f34aa39b6d365148e6f216b7815e9b4fbfdd9c37/src/chromiumos/tast/runner/features.go
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3ccfea10a581352fa02f55c4cc426cfdbcc75ff8

commit 3ccfea10a581352fa02f55c4cc426cfdbcc75ff8
Author: Daniel Erat <derat@chromium.org>
Date: Tue Sep 18 09:25:23 2018

autotest: Don't pass !"dep:android" to Tast in vm_sanity.

Update the local_test_runner command executed by
vm_sanity.py to stop explicitly excluding tests with the
"dep:android" attribute. local_test_runner will now skip
these tests automatically if the DUT doesn't provide the
"android" software feature.

BUG= chromium:882454 , chromium:876587 
TEST=ran updated command after updating local_test_runner
     and verified that android tests are skipped in simple
     chrome VM

Change-Id: Ie7f40623ff0cc42c5aeab69818c8a098108f5ab1
Reviewed-on: https://chromium-review.googlesource.com/1227692
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/3ccfea10a581352fa02f55c4cc426cfdbcc75ff8/client/bin/vm_sanity.py

Comment 3 by derat@chromium.org, Sep 24

Status: Fixed (was: Started)
►

Sign in to add a comment