New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882453 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 13
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove ArcNotificationManager::SendNotificationButtonClickedOnChrome

Project Member Reported by yoshiki@chromium.org, Sep 10

Issue description

ArcNotificationManager::SendNotificationButtonClickedOnChrome is no longer used. We can remove this safely.
 
Summary: Remove ArcNotificationManager::SendNotificationButtonClickedOnChrome (was: Remove ArcNotificationManager::SendNotificationButtonClickedOnChrome()
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ac71ddce63d827f140229d466d72982c3e4e22b

commit 5ac71ddce63d827f140229d466d72982c3e4e22b
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Sep 13 04:48:11 2018

Remove unnecessary method in ArcNotificationManager and mojom

ArcNotificationManager::SendNotificationButtonClickedOnChrome is no
longer used so this CL removes this method and related mojom call.

Bug:  882453 
Change-Id: Icb363cea1eae51ee29bb229d14ff4bbfd8516467
Reviewed-on: https://chromium-review.googlesource.com/1216124
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590926}
[modify] https://crrev.com/5ac71ddce63d827f140229d466d72982c3e4e22b/ash/system/message_center/arc/arc_notification_manager.cc
[modify] https://crrev.com/5ac71ddce63d827f140229d466d72982c3e4e22b/ash/system/message_center/arc/arc_notification_manager.h
[modify] https://crrev.com/5ac71ddce63d827f140229d466d72982c3e4e22b/components/arc/common/notifications.mojom

Status: Fixed (was: Started)

Sign in to add a comment