The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76e906b901ad098d95dddac0c77d57af5983eb9

commit a76e906b901ad098d95dddac0c77d57af5983eb9
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue Sep 11 08:28:46 2018

Use the same metric recorder for PasswordFormManager and NewPasswordFormManager.

When flag #new-password-form-parsing is on, PasswordFormManager is used for
saving and NewPasswordFormManager for filling. Now they have separate metric
recorders. Metric PasswordManager.ActionsTakenV3 (and others) is inconsistent
because filling and saving parts of this metric written with different recorders.

This CL implements usage of the same metric recorder for PasswordFormManager
and NewPasswordFormManager that corresponds for the same form.

Bug: 882432, 831123

Change-Id: I84b480c86ec8172fb9d055cd8189529c5e4f42fb
Reviewed-on: https://chromium-review.googlesource.com/1215965
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590234}
[modify] https://crrev.com/a76e906b901ad098d95dddac0c77d57af5983eb9/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/a76e906b901ad098d95dddac0c77d57af5983eb9/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/a76e906b901ad098d95dddac0c77d57af5983eb9/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/a76e906b901ad098d95dddac0c77d57af5983eb9/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/a76e906b901ad098d95dddac0c77d57af5983eb9/components/password_manager/core/browser/password_manager_unittest.cc

Requesting to merge crrev.com/590234 to M70 beta.

This has been rolled out in 71.0.{3550, 3551, 3552}.*.

The data indicates that the metrics recorded are fixed.

In https://uma.googleplex.com/p/chrome/variations/?sid=45d2214ef20b7bd41c7630f90df47836 we had an incorrect +100% increase in metrics volume. This is now well withing the 95% CI https://uma.googleplex.com/p/chrome/variations/?sid=4d87ffb195ab1573f31bd6891e7bcca5

The crash rates are also within the CIs:
https://uma.googleplex.com/p/chrome/variations/?sid=3de7b80f5233f324f44b08f5c240214a

This should be a safe merge.

This bug requires manual review: Less than 25 days to go before AppStore submit on M70
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

branch:3538

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c607981761788cfe7cb61a1ccec10de1afd742f2

commit c607981761788cfe7cb61a1ccec10de1afd742f2
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue Sep 18 07:19:32 2018

Use the same metric recorder for PasswordFormManager and NewPasswordFormManager.

When flag #new-password-form-parsing is on, PasswordFormManager is used for
saving and NewPasswordFormManager for filling. Now they have separate metric
recorders. Metric PasswordManager.ActionsTakenV3 (and others) is inconsistent
because filling and saving parts of this metric written with different recorders.

This CL implements usage of the same metric recorder for PasswordFormManager
and NewPasswordFormManager that corresponds for the same form.

Bug: 882432, 831123

Change-Id: I84b480c86ec8172fb9d055cd8189529c5e4f42fb
Reviewed-on: https://chromium-review.googlesource.com/1215965
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590234}(cherry picked from commit a76e906b901ad098d95dddac0c77d57af5983eb9)
Reviewed-on: https://chromium-review.googlesource.com/1229935
Cr-Commit-Position: refs/branch-heads/3538@{#475}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c607981761788cfe7cb61a1ccec10de1afd742f2/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/c607981761788cfe7cb61a1ccec10de1afd742f2/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/c607981761788cfe7cb61a1ccec10de1afd742f2/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/c607981761788cfe7cb61a1ccec10de1afd742f2/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/c607981761788cfe7cb61a1ccec10de1afd742f2/components/password_manager/core/browser/password_manager_unittest.cc