New issue
Advanced search Search tips

Issue 882426 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chromad: Disable anonymizer for unittests

Project Member Reported by rsorokin@chromium.org, Sep 10

Issue description

for authpolicyd
 
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
Components: Enterprise
This wouldn't have much benefit since command and output logging is turned off by default, so that the anonymizer is never called. You'd have to add

  flags_.set_log_commands(true);
  flags_.set_log_command_output(true);

to SambaInterface::ReloadDebugFlags() to turn that on. Since you have to do that, anyway, you can just add

  flags_.set_disable_anonymizer(true);

as well.


Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d11dcda88d86b3d6dcea0b130dde82cba3228b93

commit d11dcda88d86b3d6dcea0b130dde82cba3228b93
Author: Lutz Justen <ljusten@chromium.org>
Date: Fri Nov 23 03:07:42 2018

authpolicy: Add unit test to check anonymization

Adds a unit test that checks whether the anonymizer actually does
its job when debug logs are generated.

BUG= chromium:882426 
TEST=cros_workon_make --board=amd64-generic --test authpolicy

Change-Id: Iecc220261786d8f691b993330477aad12010a249
Reviewed-on: https://chromium-review.googlesource.com/1337710
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/d11dcda88d86b3d6dcea0b130dde82cba3228b93/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/d11dcda88d86b3d6dcea0b130dde82cba3228b93/authpolicy/samba_interface.h

Status: WontFix (was: Assigned)
Won't fix by comment #3. To disable the anonymizer and enable debug output, just add
  flags_.set_log_commands(true);
  flags_.set_log_command_output(true);
  flags_.set_disable_anonymizer(true);
to SambaInterface::ReloadDebugFlags().

Sign in to add a comment