Can't enter certain characters on textboxes in devtools extension panels
Reported by
ngy...@gmail.com,
Sep 10
|
|||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.9 Safari/537.36 Steps to reproduce the problem: 1. Install the attached demo extension 2. Open the inspector, go to the newly installed "devtools page test" panel (next to the Element/Console/Sources/...) 3. Attempt to enter text on the textbox What is the expected behavior? All characters typed on the keyboard should work What went wrong? On Mac Chrome 70.0.3538.9 dev and 71.0.3548.0 canary, the 'r' and 'p' keys don't work Bizarrely on Windows Chrome 71.0.3548.0 canary, the 't' and 'p' keys don't work instead Did this work before? Yes Chrome 69.0.3497.81 stable Chrome version: 70.0.3538.9 Channel: dev OS Version: OS X 10.13.6 Flash Version: N/A
,
Sep 11
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 14.04 using chrome reported version #70.0.3538.9 and latest canary #71.0.3548.0. Bisect Information: ===================== Good build: 70.0.3510.0 Bad Build : 70.0.3511.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/db24c0265e7c3b6f7ad7a5bec63484d10e66e6c0..9714881871a256c98e5b12651aedd5210319ef36 From the above change log suspecting below change Change-Id: Ide557dafed759e20dfc6698d8cdc33f932acbe83 Reviewed-on: https://chromium-review.googlesource.com/1159467 einbinder@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding stable blocker for M-70 as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Sep 17
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Sep 18
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10e9b59ba1acc764a058b8d152e3825ff7db50ba commit 10e9b59ba1acc764a058b8d152e3825ff7db50ba Author: Joel Einbinder <einbinder@chromium.org> Date: Thu Sep 20 00:47:58 2018 DevTools: Don't try to forward keypresses out of extension panels Keypress events have a different keycode, so the wrong events were being captured and sent to DevTools from extension panels. But keypress is deprecated and we don't need these events anywhere in DevTools. So we can just remove the event listener. Bug: 882422 Change-Id: I9d286f581aa77ff208463a2edbb4eea093fa98ee Reviewed-on: https://chromium-review.googlesource.com/1232853 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#592637} [modify] https://crrev.com/10e9b59ba1acc764a058b8d152e3825ff7db50ba/third_party/blink/renderer/devtools/front_end/extensions/ExtensionAPI.js
,
Sep 20
Verified the fix on mac 10.13.3, Windows-10 and Ubuntu 14.04 using Chrome version #71.0.3557.0 as per the comment #0. Attaching screen cast for reference. Observed that all characters typed on the keyboard work. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on win-10 using chrome build with out fix. Thanks...!!
,
Oct 1
[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!
,
Oct 2
einbinder@ do we need to merge this to M70? Is it a fairly safe fix?
,
Oct 4
,
Oct 4
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4
,
Oct 8
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a33afc0cefb34d8a210fa61d7c74c85399145f0 commit 7a33afc0cefb34d8a210fa61d7c74c85399145f0 Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Oct 09 18:40:55 2018 DevTools: Don't try to forward keypresses out of extension panels Keypress events have a different keycode, so the wrong events were being captured and sent to DevTools from extension panels. But keypress is deprecated and we don't need these events anywhere in DevTools. So we can just remove the event listener. Bug: 882422 Change-Id: I9d286f581aa77ff208463a2edbb4eea093fa98ee Reviewed-on: https://chromium-review.googlesource.com/1232853 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592637}(cherry picked from commit 10e9b59ba1acc764a058b8d152e3825ff7db50ba) Reviewed-on: https://chromium-review.googlesource.com/c/1271579 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#925} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/7a33afc0cefb34d8a210fa61d7c74c85399145f0/third_party/blink/renderer/devtools/front_end/extensions/ExtensionAPI.js
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a33afc0cefb34d8a210fa61d7c74c85399145f0 Commit: 7a33afc0cefb34d8a210fa61d7c74c85399145f0 Author: einbinder@chromium.org Commiter: einbinder@chromium.org Date: 2018-10-09 18:40:55 +0000 UTC DevTools: Don't try to forward keypresses out of extension panels Keypress events have a different keycode, so the wrong events were being captured and sent to DevTools from extension panels. But keypress is deprecated and we don't need these events anywhere in DevTools. So we can just remove the event listener. Bug: 882422 Change-Id: I9d286f581aa77ff208463a2edbb4eea093fa98ee Reviewed-on: https://chromium-review.googlesource.com/1232853 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592637}(cherry picked from commit 10e9b59ba1acc764a058b8d152e3825ff7db50ba) Reviewed-on: https://chromium-review.googlesource.com/c/1271579 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#925} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 10
Verified the fix on mac 10.13.3, Windows-10 and Ubuntu 17.10 using Chrome version #70.0.3538.54 as per the comment #0. Attaching screen cast for reference. Observed that all characters typed on the keyboard work i.e r, t and p. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on win-10 using chrome build with out fix. Thanks...!! |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by susan.boorgula@chromium.org
, Sep 10