New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882418 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Password Manager] Add the metric for the number of successful logins in HTTP vs HTTPS

Project Member Reported by kolos@chromium.org, Sep 10

Issue description

Add the metric for the number of successful logins in HTTP vs HTTPS
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ddc382a0059bb113ab30f2ebc16a2a42074377f

commit 7ddc382a0059bb113ab30f2ebc16a2a42074377f
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Sep 12 11:38:05 2018

[Password Manager] Add the metric for the number of successful logins on
HTTPS vs HTTP origins

Bug: 882418
Change-Id: I1d44d7292ae34a3955ef102e379ed80b5451c9fd
Reviewed-on: https://chromium-review.googlesource.com/1219004
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590645}
[modify] https://crrev.com/7ddc382a0059bb113ab30f2ebc16a2a42074377f/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/7ddc382a0059bb113ab30f2ebc16a2a42074377f/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/7ddc382a0059bb113ab30f2ebc16a2a42074377f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7ddc382a0059bb113ab30f2ebc16a2a42074377f/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-70
This CL just adds a metric. There is nothing risky, just to get important data asap.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Hotlist-Merge-Reject Merge-Reject-70
The bug is marked as P3 or Feature. It should not be merged as M70 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Why are we collecting a metric for something that other code is going to discourage RSN?  http:// URLs are already getting flagged as 'Not Secure' and Chrome tells people not to enter passwords on that page.  What are we going to do with a metric that tracks how often people entered passwords anyhow?

(Happened to see this issue while searching for another issue)
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-70 Merge-Request-70 Pri-1
Increasing priority to get this looked at by release manager. We would like to get this data asap to make decisions about future behavior of the password manager on HTTP sites.
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please mark which OS's this is impacting?
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Sure. Done.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78a8458006741d460b4547b75f33f5dc2009f0a

commit b78a8458006741d460b4547b75f33f5dc2009f0a
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Sep 18 07:24:15 2018

[Password Manager] Add the metric for the number of successful logins on
HTTPS vs HTTP origins

Bug: 882418
Change-Id: I1d44d7292ae34a3955ef102e379ed80b5451c9fd
Reviewed-on: https://chromium-review.googlesource.com/1219004
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590645}(cherry picked from commit 7ddc382a0059bb113ab30f2ebc16a2a42074377f)
Reviewed-on: https://chromium-review.googlesource.com/1229000
Cr-Commit-Position: refs/branch-heads/3538@{#476}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/tools/metrics/histograms/histograms.xml

Sign in to add a comment