[Password Manager] Add the metric for the number of successful logins in HTTP vs HTTPS |
||||||||
Issue descriptionAdd the metric for the number of successful logins in HTTP vs HTTPS
,
Sep 13
This CL just adds a metric. There is nothing risky, just to get important data asap.
,
Sep 13
The bug is marked as P3 or Feature. It should not be merged as M70 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
Why are we collecting a metric for something that other code is going to discourage RSN? http:// URLs are already getting flagged as 'Not Secure' and Chrome tells people not to enter passwords on that page. What are we going to do with a metric that tracks how often people entered passwords anyhow? (Happened to see this issue while searching for another issue)
,
Sep 14
Increasing priority to get this looked at by release manager. We would like to get this data asap to make decisions about future behavior of the password manager on HTTP sites.
,
Sep 14
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
Can you please mark which OS's this is impacting?
,
Sep 17
Sure. Done.
,
Sep 17
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b78a8458006741d460b4547b75f33f5dc2009f0a commit b78a8458006741d460b4547b75f33f5dc2009f0a Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Tue Sep 18 07:24:15 2018 [Password Manager] Add the metric for the number of successful logins on HTTPS vs HTTP origins Bug: 882418 Change-Id: I1d44d7292ae34a3955ef102e379ed80b5451c9fd Reviewed-on: https://chromium-review.googlesource.com/1219004 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590645}(cherry picked from commit 7ddc382a0059bb113ab30f2ebc16a2a42074377f) Reviewed-on: https://chromium-review.googlesource.com/1229000 Cr-Commit-Position: refs/branch-heads/3538@{#476} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/components/password_manager/core/browser/password_manager_unittest.cc [modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b78a8458006741d460b4547b75f33f5dc2009f0a/tools/metrics/histograms/histograms.xml |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 12