New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 882396 link

Starred by 3 users
Status: Fixed
Owner:
peah@chromium.org
Closed: Oct 24
Cc:
█ gustaf@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3 echo leakage under certain conditions during call startup and after delay changes

Project Member Reported by peah@chromium.org, Sep 10 
AEC3 may leak short bursts of echo during call startup and after realignments due to audio buffer changes under certain conditions.

Such conditions are
-The incoming render signal has a strong noise with a fairly stationary characteristic and the echo path at the same time has a strong gain, in which case the stationary render signal detector may cause the echo suppressor to be transparent for a brief period of time (< 1 second).

-The echo path delay change is not quickly enough reacted to by the linear filter and the echo path at the same time has a strong gain, in which case the echo suppressor may leak some short echo bursts.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b2d7116733902b9e9068992e172d72d870e54e03

commit b2d7116733902b9e9068992e172d72d870e54e03
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Sep 10 13:05:14 2018

AEC3: Correction of the suppressor behavior at delay changes

This CL adjusts the behavior of the AEC3 echo suppressor behavior
initially in the call, and when there has been delay changes. The
results is that short echo blips/bursts present in some such cases
no longer occur.

In particular this CL:
-Ensures that the suppressor back-off under stationary render
conditions does not occur until the linear filter has had the
ability to converge.
-Ensures that a previously converged filter behavior detection
is not sticky for stable and linear echo paths, which in turn
prevents echo leakage due to the more liberal echo suppressor
behavior applied on such platforms.
-Removes a bug that caused a random and jittery behavior for
the usage of the linear filter output initially in the calls
and after echo path changes

Bug:  webrtc:9737 ,  chromium:882396 
Change-Id: Id2b46e366dc58ab8137f19ed59a2034c89ca3087
Reviewed-on: https://webrtc-review.googlesource.com/99063
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24656}
[modify] https://crrev.com/b2d7116733902b9e9068992e172d72d870e54e03/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/b2d7116733902b9e9068992e172d72d870e54e03/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/b2d7116733902b9e9068992e172d72d870e54e03/modules/audio_processing/aec3/echo_audibility.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f200b4d42ac0923aa96b2f62b20615829afeb11e

commit f200b4d42ac0923aa96b2f62b20615829afeb11e
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 17:29:13 2018

Roll src/third_party/webrtc abd4273e43da..b2d711673390 (2 commits)

https://webrtc.googlesource.com/src.git/+log/abd4273e43da..b2d711673390


git log abd4273e43da..b2d711673390 --date=short --no-merges --format='%ad %ae %s'
2018-09-10 peah@webrtc.org AEC3: Correction of the suppressor behavior at delay changes
2018-09-10 danilchap@webrtc.org Allow different header extensions in 1st packet of a video frame


Created with:
  gclient setdep -r src/third_party/webrtc@b2d711673390

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:882396 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I19018fd072ff9c12a936a165fe5e1df5f6d8be64
Reviewed-on: https://chromium-review.googlesource.com/1216803
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589964}
[modify] https://crrev.com/f200b4d42ac0923aa96b2f62b20615829afeb11e/DEPS

Comment 3 by anatolid@chromium.org, Oct 12 

Is this finished?

Comment 4 by peah@chromium.org, Oct 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment