Avatar icon is not seen when signin is in Paused state for second instance.
Reported by
pranjali...@etouch.net,
Sep 10
|
|||||||||||||||||
Issue descriptionChrome version :71.0.3548.0 (Official Build) 94235d806bd7d3be1608cd07bf5118d2cb3f3187-refs/branch-heads/3548@{#1}(32/64 bit) OS: Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS What steps will reproduce the problem? 1.Fresh launch chrome and sign into chrome with valid credentials. 2.After successful sign in ,now sign out from gmail account. 3.Navigate to 'chrome://settings/people' and click on 'Turn Of' button. 4.Again sign into chrome account and repeat step 2. 5.Observe. Actual : Avatar icon is not seen when signin is in Paused state for second instance. Expected: Avatar icon should be seen when signin is in Paused state for second instance. This is Non-Regression issue seen from ‘M-70’ as this new UI of sign in has been introduced from build #70.0.3526.0
,
Sep 12
If you wait and reload the settings page after a while, does the icon show up?
,
Sep 12
Sorry, question was for you :)
,
Sep 14
With respect to comment#3, Rechecked the above issue on canary#71.0.3551.0 .After reloading setting page ,icon is visible. Kindly refer attached screencast. Thank You.
,
Sep 21
,
Sep 21
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edb96f4c8078a16000a8687a9afeada9c39e9cde commit edb96f4c8078a16000a8687a9afeada9c39e9cde Author: Thomas Tangl <tangltom@chromium.org> Date: Sat Sep 22 15:21:05 2018 [Dice] Update settings when account image is updated When the account image is updated in the background, settings is now notified to make changes accordingly. Bug: 882384 Change-Id: I05000533de1205fc5b9d9a9500b4c05f088e8923 Reviewed-on: https://chromium-review.googlesource.com/1238501 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593443} [modify] https://crrev.com/edb96f4c8078a16000a8687a9afeada9c39e9cde/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/edb96f4c8078a16000a8687a9afeada9c39e9cde/chrome/browser/ui/webui/settings/people_handler.h
,
Sep 22
,
Sep 25
Update: Verified the fix on Windows(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) as per comment#0 using latest canary build#71.0.3561.0 and fix is working as intended. Hence Adding the verified labels. Attaching screen cast for reference
,
Sep 25
Verified on Canary as well. Requesting merge. Merge is safe, because it just adds a notification to update the settings page. No layout changes involved.
,
Sep 25
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25
,
Sep 25
,
Sep 25
,
Sep 25
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25
+msarda@/ewald@ - is this something we should merge for M70?
,
Sep 25
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494 commit b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494 Author: Thomas Tangl <tangltom@chromium.org> Date: Tue Sep 25 21:55:25 2018 [Dice] Update settings when account image is updated When the account image is updated in the background, settings is now notified to make changes accordingly. Bug: 882384 Change-Id: I05000533de1205fc5b9d9a9500b4c05f088e8923 Reviewed-on: https://chromium-review.googlesource.com/1238501 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593443}(cherry picked from commit edb96f4c8078a16000a8687a9afeada9c39e9cde) Reviewed-on: https://chromium-review.googlesource.com/1244756 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#671} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494/chrome/browser/ui/webui/settings/people_handler.h
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494 Commit: b5a6bb4e1cd2d9289e658645fa2d118fa0fbd494 Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-09-25 21:55:25 +0000 UTC [Dice] Update settings when account image is updated When the account image is updated in the background, settings is now notified to make changes accordingly. Bug: 882384 Change-Id: I05000533de1205fc5b9d9a9500b4c05f088e8923 Reviewed-on: https://chromium-review.googlesource.com/1238501 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593443}(cherry picked from commit edb96f4c8078a16000a8687a9afeada9c39e9cde) Reviewed-on: https://chromium-review.googlesource.com/1244756 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#671} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 26
Verified the fix on Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS using latest Beta build#70.0.3538.35 as per comment#0.The fix is working as intended ,hence adding the verified labels. Attaching screen cast for reference. Thank You... |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Sep 10