New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882382 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task


Sign in to add a comment

Android Permissions UI bugs and missing features

Project Member Reported by andypaicu@chromium.org, Sep 10

Issue description

Currently the Android Permission UI has a number of problems, bugs in functionality and missing features.

This bug tracks these issues


 
Blockedon: 748109 826681 804056 814106 468586 806615
Components: UI>Browser>Permissions
Cc: andypaicu@chromium.org
Labels: Related
There are also related issues that are non-blocking:

crbug.com/729539
crbug.com/777503
crbug.com/845018
Labels: -Related
Labels: OS-Android
Cc: dullweber@chromium.org hkamila@chromium.org
Labels: Hotlist-Permissions
Thanks a lot for collecting these issues, Andy!
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc

commit 02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc
Author: Kamila <hkamila@google.com>
Date: Mon Oct 08 09:50:28 2018

Added flag for Android Permissions UI

Permissions UI in Android is being modified, in order to introduce new
functionalities and fix existing bugs.

This cl adds an experimental flag for Android Permissions UI changes,
associated with the bug below.

Bug: 882382
Change-Id: I2a332b312a228deb7b257f68cdb16b65495959b3
Reviewed-on: https://chromium-review.googlesource.com/c/1256564
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597511}
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/browser/about_flags.cc
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/02f7e07b9d47f1a7ef19012cf7c4bef07a50b4dc/tools/metrics/histograms/enums.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38aaae98398c75e0644b78be5b7c8f7f0e5e9470

commit 38aaae98398c75e0644b78be5b7c8f7f0e5e9470
Author: Kamila <hkamila@google.com>
Date: Wed Oct 17 13:10:45 2018

Changed from "Allow..." to "Block third-party cookies" on Android

Changed "Allow third-party cookies" (default-checked), to "Block third-party cookies"
(default-unchecked) in Android, to match the Desktop option.

"Block..." language was chosen, due to expressing direct intent of the user using
this option.

Link to the slides where this bug was discussed (s6):
https://docs.google.com/presentation/d/1ZFtyGpfeZxCIXPYftwyvB5pnOiGhMJenDX3KbDbyINQ/edit?usp=sharing

Bug:882382

Change-Id: I05339306646e0f50b5cb50628a8fb93465a80f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1238461
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600371}
[modify] https://crrev.com/38aaae98398c75e0644b78be5b7c8f7f0e5e9470/chrome/android/java/res/xml/website_preferences.xml
[modify] https://crrev.com/38aaae98398c75e0644b78be5b7c8f7f0e5e9470/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/38aaae98398c75e0644b78be5b7c8f7f0e5e9470/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/38aaae98398c75e0644b78be5b7c8f7f0e5e9470/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/472a594f20c93a9ee11205557eb6d98841d0118b

commit 472a594f20c93a9ee11205557eb6d98841d0118b
Author: Kamila <hkamila@google.com>
Date: Mon Nov 26 09:48:27 2018

Renamed flag to ANDROID_SITE_SETTINGS_UI_REFRESH

Renamed the flag from ANDROID_SITE_SETTINGS_UI to
ANDROID_SITE_SETTINGS_UI_REFRESH for more accuracy about what the flag
covers.

Bug: 882382
Change-Id: I914a742c89f71036cacae513ae735fb46666a6c8
Reviewed-on: https://chromium-review.googlesource.com/c/1344069
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610793}
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/about_flags.cc
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/flag-metadata.json
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/472a594f20c93a9ee11205557eb6d98841d0118b/tools/metrics/histograms/enums.xml

Sign in to add a comment