New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: 'Unlock device to perform the notification action' message is seen chopped and misplaced when rotated in Lock screen

Project Member Reported by kebalaji@chromium.org, Sep 10

Issue description

Chrome Version: 70.0.3538.14/11021.11.0 dev channel Daisy,Kip,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Lock the screen
(2)Click on ubertray and then on Change button and rotate the screen
(3)Observe 'Unlock device to perform the notification action' message is seen chopped and misplaced for 90/270 degrees.

Actual: 'Unlock device to perform the notification action' message is seen chopped and misplaced for 90/270 degrees.
Expected: No such issue should be seen

This is a Non-Regression issue seen from 70.0.3538.0/11030.0.0 dev 

 
ActualLockRotate.mp4
5.8 MB View Download
ActualRotateLock.png
170 KB View Download
Owner: yoshiki@chromium.org
yoshiki@ for triage, this is unrelated to login/lock.
Labels: -M-70 M-71
Changed the target milestone. This feature is not launched on M70.
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fa0219bc385114d6aa16654b060fceb06c4f743

commit 8fa0219bc385114d6aa16654b060fceb06c4f743
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Oct 04 05:56:09 2018

Update bounds of toast when the display metrics is changed

Previously the position of toast was not updated when the display
size is changed and it might keep visible on wrong place.

This CL adds the code to update the location if the display metrics
is changed.

Bug:  882371 
Change-Id: Ia416f9fa8dbbcd081b578c37da6826846da243f0
Reviewed-on: https://chromium-review.googlesource.com/c/1258746
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596519}
[modify] https://crrev.com/8fa0219bc385114d6aa16654b060fceb06c4f743/ash/system/toast/toast_overlay.cc
[modify] https://crrev.com/8fa0219bc385114d6aa16654b060fceb06c4f743/ash/system/toast/toast_overlay.h

Status: Fixed (was: Assigned)

Sign in to add a comment