Issue metadata
Sign in to add a comment
|
Pressing Cmd-L twice doesn't expand URL |
||||||||||||||||||||||||
Issue descriptionChrome 69.0.3497.81 macOS 10.13.6 What steps will reproduce the problem? (1) Press the URL twice (2) Deselect the URL bar and press Cmd-L twice What is the expected result? The expanded URL is visible (including scheme and elided subdomains) after both step 1 and step 2. What happens instead? Only the shortened URL is visible after step 2, but the full URL is visible after step 1.
,
Sep 10
Marking as a feature request. Please feel free to relabel as a bug, if I am wrong. Thanks :)
,
Sep 11
Can repro on Windows as well. Though as soon as I type an arrow key, home, end, I'm able to see and edit the full URL. Is having conditional/modal behavior for Ctrl-L desirable? I'm not sure I can make that call. Justin, Lucas, Security Consistency folks, suggestions welcome as to whether this should be triaged as a bug or wontfix'ed to establish as desired behavior.
,
Sep 11
,
Sep 20
I don't know if I'm qualified to make judgments, but I certainly *expect* this to work like clicking.
,
Oct 12
tommycli has actually already implemented the requested behavior, though currently only in the case that you have chrome://flags/#enable-query-in-omnibox enabled. We agree that the requested behavior makes sense but we want to have a chance to evaluate it before enabling it by default just in case there are any gotchas we haven't anticipated.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/575dc09174cfeff0f04ac4b9b27733b584cfea57 commit 575dc09174cfeff0f04ac4b9b27733b584cfea57 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Oct 29 19:23:48 2018 Omnibox: Make a single Ctrl+L reveal the full URL After this CL, a single Ctrl+L will reveal the full URL. This applies to beth Query in Omnibox and Steady State Elisions. This CL also adds a unit test, as well as an internal-only killswitch in case we need to remotely disable this feature. Bug: 874592, 882348 Change-Id: I6bce176e613b46bfc9b6ce524ddf855bdb14f399 Reviewed-on: https://chromium-review.googlesource.com/c/1285511 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603584} [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/omnibox_view.h [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/test_toolbar_model.cc [modify] https://crrev.com/575dc09174cfeff0f04ac4b9b27733b584cfea57/components/omnibox/browser/test_toolbar_model.h
,
Oct 31
> Omnibox: Make a single Ctrl+L reveal the full URL It would be nice, if this could also be the case when clicking with the mouse curser into the Omnibox (for consistency reasons). Thanks :) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Sep 10