New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrOS autotest telemetry_Benchmarks.rendering.desktop failed

Project Member Reported by vovoy@chromium.org, Sep 10

Issue description

Traceback (most recent call last):
  RunBenchmark at /home/chromeos-test/images/gandof-release/R71-11054.0.0/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:369
    expectations=expectations, max_num_values=benchmark.MAX_NUM_VALUES)
  Run at /home/chromeos-test/images/gandof-release/R71-11054.0.0/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:187
    story_set.bucket)
  GetFilesInDirectoryIfChanged at /home/chromeos-test/images/gandof-release/R71-11054.0.0/telemetry_src/src/third_party/catapult/common/py_utils/py_utils/cloud_storage.py:474
    '%s does not exist. Must provide a valid directory path.' % directory)
ValueError: /home/chromeos-test/images/gandof-release/R71-11054.0.0/telemetry_src/src/chrome/test/data/perf/tough_compositor_cases does not exist. Must provide a valid directory path.

CrOS devserver doesn't contain the full chromium source tree.

The CrOS autotest runs rendering.desktop with flag --story-tag-filter=top_real_world_desktop, tough_compositor_cases test is not included.

If story_runner doesn't download unnecessary files with GetFilesInDirectoryIfChanged(), this failure could be avoided.
 
If we need to run tough_compositor_cases on test_that, src/chrome/test/data/perf/tough_compositor_cases would also need to included in the CrOS telemetry tarball.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e091547de21a7b4678d4313ee081fc110bfcbc74

commit e091547de21a7b4678d4313ee081fc110bfcbc74
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Mon Sep 10 15:14:07 2018

telemetry_Benchmarks: add some tests to ON_DUT_BLACKLIST

Add loading.desktop and rendering.desktop to ON_DUT_BLACKLIST.

BUG= chromium:882291 ,  chromium:882299 
TEST=running autotest loading.desktop and rendering.desktop

Change-Id: I6b4f6496a5374aa84c839755f4d4c7743c5c4f20
Reviewed-on: https://chromium-review.googlesource.com/1215103
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/e091547de21a7b4678d4313ee081fc110bfcbc74/server/cros/telemetry_runner.py

Description: Show this description
Cc: nednguyen@chromium.org
Components: -Tests Tests>Telemetry
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/572c25286dc6b891ef4f2146afa83c573a3c83de

commit 572c25286dc6b891ef4f2146afa83c573a3c83de
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Thu Sep 13 16:52:37 2018

Only download files for filtered stories in story_runner

Calling GetFilesInDirectoryIfChanged() only for filtered stories to
avoid unnecessary downloads.

Bug:  chromium:882291 
Change-Id: Ifabcd97dc7c8f85463a171eb75401e626cbf8632
Reviewed-on: https://chromium-review.googlesource.com/1220967
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/572c25286dc6b891ef4f2146afa83c573a3c83de/telemetry/telemetry/internal/story_runner.py
[modify] https://crrev.com/572c25286dc6b891ef4f2146afa83c573a3c83de/telemetry/telemetry/internal/story_runner_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/183cce16109961192d25d0fcc82fa9529ba15428

commit 183cce16109961192d25d0fcc82fa9529ba15428
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 13 20:35:27 2018

Roll src/third_party/catapult 5f6da8a57db1..572c25286dc6 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/5f6da8a57db1..572c25286dc6


git log 5f6da8a57db1..572c25286dc6 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner


Created with:
  gclient setdep -r src/third_party/catapult@572c25286dc6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:882291 
TBR=sullivan@chromium.org

Change-Id: I21b7895c23abe6fa3f370e025c322640825c5ce4
Reviewed-on: https://chromium-review.googlesource.com/1225310
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591138}
[modify] https://crrev.com/183cce16109961192d25d0fcc82fa9529ba15428/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35

commit 8323f92cb0c81332c00abfe5a3bad012a400fd35
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 14 16:52:21 2018

Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813


git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle
2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story."
2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads
2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws.
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries
2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG.
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@9f36d9f78813

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861
Reviewed-on: https://chromium-review.googlesource.com/1226380
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591375}
[modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS

Sign in to add a comment