New issue
Advanced search Search tips

Issue 882285 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

CSS: default is not a custom-ident

Project Member Reported by ericwilligers@chromium.org, Sep 10

Issue description

https://drafts.csswg.org/css-values-4/#custom-idents
The default keyword is reserved and is also not a valid <custom-ident>.

None of the following CSS properties should accept  default:
- animation-name
- counter-increment
- counter-reset
- grid-template-columns
- grid-template-rows

Firefox rejects  default  for each of these.

Blink currently only rejects  default  for grid-template-columns and grid-template-rows.
http://jsfiddle.net/ericwilligers/sdhcyzv5/


We should deprecate and remove support for default in animation-name/counter-increment/counter-reset.

 
For new contributors: Note that this will need an Intent.
https://www.chromium.org/blink/removing-features

Cc: andruud@chromium.org
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
WPT: external/wpt/css/css-animations/parsing/animation-name-invalid.html
WPT failure detected in https://bugs.chromium.org/p/chromium/issues/detail?id=882251

Labels: Hotlist-GoodFirstBug
I would like to take this issue if nobody is working on it yet.
eui-sang.lim@: go for it! 🙂
Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
UseCounter will be added in https://chromium-review.googlesource.com/c/chromium/src/+/1325599

The patch below would be the fix when we decide to remove the feature in the future.
https://chromium-review.googlesource.com/c/chromium/src/+/1325581

I will make it in review status with an 'Intent To Deprecate And Remove' drafts.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f15ef93311513a72582ac3e15702710b73f0269

commit 1f15ef93311513a72582ac3e15702710b73f0269
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Tue Nov 13 23:42:06 2018

Add a UseCounter for default in custom-ident

The default keyword is reserved and is also not a valid <custom-ident>.[1]
We should deprecate and remove support for default in custom-ident.
Add a UseCounter for default in custom-ident.

[1]: https://drafts.csswg.org/css-values-4/#custom-idents

Bug: 882285
Change-Id: I1c102200a641c6a2a1266a95a682e367f28b6d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1325599
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607809}
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/css_syntax_descriptor.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.h
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/parser/css_property_parser_test.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/css_parsing_utils.h
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/content_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/counter_increment_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/counter_reset_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/display_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_auto_columns_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_auto_rows_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_column_end_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_column_start_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_row_end_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_row_start_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_template_columns_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/grid_template_rows_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/page_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/longhands/transition_property_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/shorthands/grid_area_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/shorthands/grid_column_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/shorthands/grid_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/shorthands/grid_row_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/third_party/blink/renderer/core/css/properties/shorthands/transition_custom.cc
[modify] https://crrev.com/1f15ef93311513a72582ac3e15702710b73f0269/tools/metrics/histograms/enums.xml

Sign in to add a comment