New issue
Advanced search Search tips

Issue 882234 link

Starred by 2 users
Status: Fixed
Owner:
eseckler@chromium.org
Closed: Sep 10
Cc:
wychen@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

underspeciifed gn dependencies around base/location.h, at least in nocompile tests

Project Member Reported by thakis@chromium.org, Sep 9 
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935856997875971520/+/steps/compile/0/stdout

FAILED: gen/content/test/browser_task_traits_unittest_nc.cc 
python ../../tools/nocompile_driver.py 4 ../../content/public/browser/browser_task_traits_unittest.nc gen/content/test/browser_task_traits_unittest_nc.cc -- -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -std=c++14 -Wall -Werror -Wfatal-errors -Wthread-safety -I../../ -Igen --sysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
In file included from ../../content/public/browser/browser_task_traits_unittest.nc:9:
In file included from ../../content/public/browser/browser_task_traits.h:11:
In file included from ../../content/public/browser/browser_thread.h:13:
../../base/location.h:14:10: fatal error: 'base/debug/debugging_buildflags.h' file not found
#include "base/debug/debugging_buildflags.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Comment 1 by wychen@chromium.org, Sep 10

Cc: wychen@chromium.org
Owner: eseckler@chromium.org
Status: Assigned (was: Untriaged)
I'm a bit confused how this could happen.

base/location.h is only referenced in target //base, and //base has //base:debugging_buildflags as public_deps. Target content_nocompile_tests also has //base as deps.

eseckler@, would you mind following up this issue?

My best guess is that in the section action_foreach(nocompile_target) in file build/nocompile.gni, invoker.deps needs to be manually carried over. I'm not sure whether deps would be automatically inherited in templates. Maybe not given this error.

Comment 2 by thakis@chromium.org, Sep 10

Cc: thakis@chromium.org
 Issue 882328  has been merged into this issue.

Comment 3 by eseckler@chromium.org, Sep 10

Status: Started (was: Assigned)
Will try to do what wychen@ suggested in #1 :)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb2a899dd5bcf5d7801a69f2e99d04ea7393955d

commit fb2a899dd5bcf5d7801a69f2e99d04ea7393955d
Author: Eric Seckler <eseckler@chromium.org>
Date: Mon Sep 10 15:25:30 2018

build: Pass on dependencies of nocompile tests

Add the dependencies of the invoker target to the generated nocompile
targets. This should address the flakiness issues of building
content_nocompile_tests.

Bug:  882234 
Change-Id: Ic7f7a07d3a6567202b3a0da8800228c7329f119d
Reviewed-on: https://chromium-review.googlesource.com/1215964
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589918}
[modify] https://crrev.com/fb2a899dd5bcf5d7801a69f2e99d04ea7393955d/build/nocompile.gni

Comment 5 by wychen@chromium.org, Sep 10

Status: Fixed (was: Started)
►

Sign in to add a comment