Title bar height increases with any theme.
Reported by
kohltast...@gmail.com,
Sep 9
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36 Steps to reproduce the problem: 1. Add any chrome theme 2. Notice title bar height change What is the expected behavior? No title bar height change. What went wrong? Title bar height changed dramatically. Did this work before? N/A Chrome version: 69.0.3497.81 Channel: stable OS Version: 10.0 Flash Version:
,
Sep 9
,
Sep 9
May be hard to notice for most, but with a low resolution monitor every pixel counts.
,
Sep 9
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 9
Interesting. Looks like the drag zone increases when installing a theme.
,
Sep 10
It's not "any" theme; it's any theme where background tab shapes are visible. We can't extend the window drag handle into the background tabs as we do in the default theme, so we enlarge the top height enough to still provide at least 8 DIP of top drag handle.
,
Sep 10
I can still drag anywhere above the background tabs and see nothing that would warrant the random height change on my setup. I'm not sure what issue you are referring to with the background tab shapes.
,
Sep 10
I just tested it with a theme I created that uses no custom images, only color and tint, the issue still occurs.
,
Sep 10
Issue 882355 has been merged into this issue.
,
Sep 10
,
Sep 10
@8: In the screenshot in comment 3, note how the "settings" tab is not the same color as the window frame. In the default theme, background tabs are the same color as the frame (so they appear not to exist and text is just drawn on the frame directly). When they're the same color, we can use the top few pixels of them as window drag area, but when they aren't, we can't, because it feels wrong to hover the tab and yet have clicking move the window. So in the default theme only 4 px above the tabs (on Windows) are used for window dragging, and another 6 px come from inside the tab. But with background tab shapes visible, we increase the top height enough to get 8 px of drag above the tabs (and 0 px of drag inside theme).
,
Sep 10
Thank you for the response, I understand the issue I was having. I got confused when you said background tab shapes and thought you were referring to images. Once again, thank you for taking the time to clarify my misunderstanding. :)
,
Sep 10
No problem, glad we could get on the same page :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meh...@chromium.org
, Sep 9Labels: Needs-Feedback