Issue metadata
Sign in to add a comment
|
NavigatingExtensionPopupBrowserTest.PageInSameExtension is flaky |
||||||||||||||||||||||
Issue descriptionFindit has detected flake occurrences for the test NavigatingExtensionPopupBrowserTest.PageInSameExtension Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NavigatingExtensionPopupBrowserTest.PageInSameExtension&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
,
Sep 11
I believe farahcharab@ is no longer active.
,
Sep 11
Ok, I'm reverting it...
,
Sep 11
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ce3af5c962d5692f2979846628f3c4b8ceb3e30 commit 3ce3af5c962d5692f2979846628f3c4b8ceb3e30 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Sep 11 06:49:33 2018 Revert "Scheduler: WebURLLoader should notify Blink with the initial priority." This reverts commit d2bade563869c5a429d129695ce754ca0f5e9507. Reason for revert: Speculative revert for test failure. https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Original change's description: > Scheduler: WebURLLoader should notify Blink with the initial priority. > > The loading stack only notifies Blink with any increase in the > request priority. Add support to notify the scheduler with the > initial priority as well. > > Bug: 870349 > Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b > Reviewed-on: https://chromium-review.googlesource.com/1185593 > Commit-Queue: Farah Charab <farahcharab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586752} TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870349, 882200 Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051 Reviewed-on: https://chromium-review.googlesource.com/1218263 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590218} [modify] https://crrev.com/3ce3af5c962d5692f2979846628f3c4b8ceb3e30/content/renderer/loader/web_url_loader_impl.cc
,
Sep 12
The revert didn't fix the flakiness. I'm relanding the original CL.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fbd6bbc97324bc72d8fcb7bb7a846399517fdee commit 9fbd6bbc97324bc72d8fcb7bb7a846399517fdee Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Sep 12 02:22:52 2018 Reland "Scheduler: WebURLLoader should notify Blink with the initial priority." This reverts commit 3ce3af5c962d5692f2979846628f3c4b8ceb3e30. Reason for revert: Revert didn't fix the flakiness. Original change's description: > Revert "Scheduler: WebURLLoader should notify Blink with the initial priority." > > This reverts commit d2bade563869c5a429d129695ce754ca0f5e9507. > > Reason for revert: Speculative revert for test failure. > https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw > > Original change's description: > > Scheduler: WebURLLoader should notify Blink with the initial priority. > > > > The loading stack only notifies Blink with any increase in the > > request priority. Add support to notify the scheduler with the > > initial priority as well. > > > > Bug: 870349 > > Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b > > Reviewed-on: https://chromium-review.googlesource.com/1185593 > > Commit-Queue: Farah Charab <farahcharab@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586752} > > TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 870349, 882200 > Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051 > Reviewed-on: https://chromium-review.googlesource.com/1218263 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590218} TBR=kinuko@chromium.org,yhirano@chromium.org,altimin@chromium.org,farahcharab@chromium.org Change-Id: I1b363f0f4c7396ccf1cdc7b67b436602e8738df3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870349, 882200 Reviewed-on: https://chromium-review.googlesource.com/1220409 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#590576} [modify] https://crrev.com/9fbd6bbc97324bc72d8fcb7bb7a846399517fdee/content/renderer/loader/web_url_loader_impl.cc
,
Sep 12
,
Sep 12
+lukasza who is the test's author. Looking at the flakiness dashboard, it appears that this test has been timing out on multiple bots for a while. We should probably disable this test.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0aa1d863e004a8fa3255bd09217191ae3d68394 commit d0aa1d863e004a8fa3255bd09217191ae3d68394 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Sep 12 15:44:46 2018 Disable NavigatingExtensionPopupBrowserTest.PageInSameExtension Tbr: lukasza@chromium.org, tbarzic@chromium.org No-Try: true Bug: 882200 Change-Id: Id0338970efe523569ed69227a024abaa1893ffbb Reviewed-on: https://chromium-review.googlesource.com/1221478 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#590696} [modify] https://crrev.com/d0aa1d863e004a8fa3255bd09217191ae3d68394/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
,
Sep 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yhirano@chromium.org
, Sep 10Labels: -Sheriff-Chromium
Owner: farahcharab@chromium.org
Status: Assigned (was: Untriaged)