New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug

Blocking:
issue 872403



Sign in to add a comment

bluetoothd pre-start script failed

Project Member Reported by sonnysasaka@chromium.org, Sep 9

Issue description

mkfifo failed when /run/bluetooth/fifo already exists.
This causes bluetoothd not able to recover if it crashes.
 
Blocking: 872403
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dd951b725849dbb1461f8b02ee4be59e8a141ed2

commit dd951b725849dbb1461f8b02ee4be59e8a141ed2
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Sun Sep 09 17:33:50 2018

bluez: Fix mkfifo already exists

When bluetoothd crashes, it fails to restart because pre-start script
fails when trying to create the already existing /run/bluetooth/fifo
file. Creating this file should be guarded with "if not exists",
additionally this should be moved to bluetoothlog-upstart.conf instead
of bluez-upstart.conf because this has nothing to do with bluez, to
minimize any other possible regression that affects bluez.

BUG= chromium:882198 
TEST=run "restart bluetoothd" and it should succeed
     run "start bluetoothlog", "kill $(pidof btmon)", check that log
     file is written to /var/log/bluetooth/log.gz

Change-Id: Ib37c87da7ef9b856dbd39bd84c8330c848b8b1d6
Reviewed-on: https://chromium-review.googlesource.com/1214824
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/dd951b725849dbb1461f8b02ee4be59e8a141ed2/net-wireless/bluez/files/bluetoothlog-upstart.conf
[modify] https://crrev.com/dd951b725849dbb1461f8b02ee4be59e8a141ed2/net-wireless/bluez/files/bluez-upstart.conf

Labels: Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 10

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 10

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/385d672dccb88c9eb8a86ad46d6b759643d10b62

commit 385d672dccb88c9eb8a86ad46d6b759643d10b62
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Mon Sep 10 22:45:44 2018

bluez: Fix mkfifo already exists

When bluetoothd crashes, it fails to restart because pre-start script
fails when trying to create the already existing /run/bluetooth/fifo
file. Creating this file should be guarded with "if not exists",
additionally this should be moved to bluetoothlog-upstart.conf instead
of bluez-upstart.conf because this has nothing to do with bluez, to
minimize any other possible regression that affects bluez.

BUG= chromium:882198 
TEST=run "restart bluetoothd" and it should succeed
     run "start bluetoothlog", "kill $(pidof btmon)", check that log
     file is written to /var/log/bluetooth/log.gz

Change-Id: Ib37c87da7ef9b856dbd39bd84c8330c848b8b1d6
Reviewed-on: https://chromium-review.googlesource.com/1214824
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit dd951b725849dbb1461f8b02ee4be59e8a141ed2)
Reviewed-on: https://chromium-review.googlesource.com/1217625
Reviewed-by: Qiyu Hu <qiyuh@google.com>
Commit-Queue: Qiyu Hu <qiyuh@google.com>

[modify] https://crrev.com/385d672dccb88c9eb8a86ad46d6b759643d10b62/net-wireless/bluez/files/bluetoothlog-upstart.conf
[modify] https://crrev.com/385d672dccb88c9eb8a86ad46d6b759643d10b62/net-wireless/bluez/files/bluez-upstart.conf

Status: Fixed (was: Started)
Marking this fixed.
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 14

Cc: cindyb@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-69
Labels: Merge-Request-70
We need this patch in R70 too to fix the bluetoothd daemon crash issue. Thanks!
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 1

Labels: -Merge-Request-70 Merge-Review-70
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 2

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/de2145e4b3896e87b011d740a8fb63f25939afe5

commit de2145e4b3896e87b011d740a8fb63f25939afe5
Author: Sonny Sasaka <sonnysasaka@chromium.org>
Date: Tue Oct 02 13:56:19 2018

bluez: Fix mkfifo already exists

When bluetoothd crashes, it fails to restart because pre-start script
fails when trying to create the already existing /run/bluetooth/fifo
file. Creating this file should be guarded with "if not exists",
additionally this should be moved to bluetoothlog-upstart.conf instead
of bluez-upstart.conf because this has nothing to do with bluez, to
minimize any other possible regression that affects bluez.

BUG= chromium:882198 
TEST=run "restart bluetoothd" and it should succeed
     run "start bluetoothlog", "kill $(pidof btmon)", check that log
     file is written to /var/log/bluetooth/log.gz

Change-Id: Ib37c87da7ef9b856dbd39bd84c8330c848b8b1d6
Reviewed-on: https://chromium-review.googlesource.com/1214824
Commit-Ready: Sonny Sasaka <sonnysasaka@chromium.org>
Tested-by: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit dd951b725849dbb1461f8b02ee4be59e8a141ed2)
Reviewed-on: https://chromium-review.googlesource.com/1253370
Reviewed-by: Qiyu Hu <qiyuh@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@chromium.org>
Tested-by: Qiyu Hu <qiyuh@chromium.org>

[modify] https://crrev.com/de2145e4b3896e87b011d740a8fb63f25939afe5/net-wireless/bluez/files/bluetoothlog-upstart.conf
[modify] https://crrev.com/de2145e4b3896e87b011d740a8fb63f25939afe5/net-wireless/bluez/files/bluez-upstart.conf

Labels: -Merge-Approved-70

Sign in to add a comment