New issue
Advanced search Search tips

Issue 882166 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Command + V Does Not Paste Text into Omnibox if it's overridden to default to "paste and match style" in system perferences

Reported by kevinweh...@gmail.com, Sep 8

Issue description

Chrome Version       : 69.0.3497.81
OS Version: OS X 10.13.6
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: Pass
    Firefox: Do not use
    IE/Edge: Do not use

What steps will reproduce the problem?
1. Copy some text to the clipboard
2. Click in Omnibox
3. Press Command + V
4. Edit menu item flickers
5. No text displays in Omnibox

What is the expected result?
Pasted text should display in Omnibox

What happens instead of that?
Nothing, the Omnibox remains blank

Please provide any additional information below. Attach a screenshot if
possible. Using the mouse, right click > Paste does work

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36



 
Components: UI>Input>KeyboardShortcuts
Labels: Needs-Feedback
Thanks for the report. Which Keyboard Language Layout are you using? Can you please try latest Chrome Canary, if it is still an issue there? Thanks in advance.
Labels: Needs-Triage-M69
Components: UI>Browser>Omnibox
mehmet@'s questions:
1) Which keyboard language layout?
2) If possible, can you see if this work on Chrome canary?

a few new ones:
3) Does it matter what's in the Omnibox when you paste? For example, is it broken in cases (a) all text is highlighted, and (b) Omnibox text has been deleted and is blank with a cursor there?
4) Does Command-V work in other contexts in the OS? Thanks for the report that you tested on safari; does it work for example in the google.com search box in Chrome?

Thank you!



I've got this issue.
1) I use a standard US layout.
2) I have a hard time reproducing, I couldnt reproduce in Canary.
3) Yes, I think it does, I think rich text doesn't paste
4) Command V does work in other contexts.

I can't speak for others, but I'd guess this relates to a preference that I've set to prefer "Paste and Match Style" over just "Paste". I realize this is a personal config, but I feel like you could probably implement a handler of sorts so that this input is handled as it used to be.

Thanks.
Facing the exact same issue. Additional info : it starts working once we manually paste by going to Edit > Paste until we quit Chrome.

I have "Paste and Match Style" over just "Paste" enabled too. But, it has been so since a really long time. I can confirm it worked earlier just fine. 

Maybe upgrading to Mojave changed something (my Chrome updated at the same time)? 

I am attaching a video showing complete behaviour.
Screen Recording 2018-09-27 at 7.12.40 PM.mov
8.0 MB View Download
> I think rich text doesn't paste

Plain text shows the exact same behaviour [see the video in above comment].
Labels: -Needs-Feedback
Cc: ellyjo...@chromium.org
Labels: Proj-MacViews
Status: Untriaged (was: Unconfirmed)
Summary: Command + V Does Not Paste Text into Omnibox if it's overridden to default to "paste and match style" in system perferences (was: Command + V Does Not Paste Text into Omnibox)
I can repro this. Add an override like described on https://www.macobserver.com/tmo/article/something-copy-paste , relaunch chrome, and cmd-v only works in the content area, not in the omnibox.
Owner: erikc...@chromium.org
Erik, you've made shortcut changes.
Status: Assigned (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344

commit fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344
Author: erikchen <erikchen@chromium.org>
Date: Wed Oct 03 17:48:27 2018

Fix paste without style on macOS.

NSViews in Views need to implement pasteAndMatchStyle:.

The IDS_PASTE_MATCH_STYLE_MAC main menu item had the wrong key equivalent.

Bug:  882166 
Change-Id: I0ba029afddaab8e155d5cfadaccadf2c231a3e79
Reviewed-on: https://chromium-review.googlesource.com/1255864
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596280}
[modify] https://crrev.com/fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344/chrome/browser/ui/cocoa/main_menu_builder.mm
[modify] https://crrev.com/fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344/ui/views_bridge_mac/bridged_content_view.mm

Status: Fixed (was: Assigned)
Thank you Eric! :) Will this be available on next stable release?
Labels: Merge-Request-70
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 3

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e8f10472b7f5618c5f31d696b49fdeb0067053c

commit 7e8f10472b7f5618c5f31d696b49fdeb0067053c
Author: erikchen <erikchen@chromium.org>
Date: Wed Oct 03 18:48:25 2018

Add DCHECK to main menu builder.

The shift modifier is *almost* always incorrect to use for menu items -- it is
instead appropriate to apply the shift modifier directly to the keyEquivalent.

Bug:  882166 
Change-Id: I6507a2a8981241cb1b80a8737213c5ac45fdab2e
Reviewed-on: https://chromium-review.googlesource.com/1259362
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596299}
[modify] https://crrev.com/7e8f10472b7f5618c5f31d696b49fdeb0067053c/chrome/browser/ui/cocoa/main_menu_builder.h

Labels: TE-Verified-71.0.3570.0 TE-Verified-M71
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix.

Verified the fix on Mac 10.13.3 using Chrome version #71.0.3570.0 as per the comment #0.
Attaching screen cast for reference.
Observed that pasted text is displayed in omnibox as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
882166.mp4
849 KB View Download
Labels: -Merge-Review-70 Merge-Approved-70
Labels: -Merge-Approved-70
CL doesn't merge cleanly -- looks like files have been moved around. Given that this is a relatively low impact build, I'm going to refrain from merging to Beta at such a late date in the cycle.
Cc: swarnasree.mukkala@chromium.org
 Issue 893467  has been merged into this issue.
Still reproducible in Chrome Version 70.0.3538.67 (Official Build) (64-bit).
#21: Correct - this was not fixed in 70.0.
This bug also affects the command + f search dialog.


882166 - Paste As Matching Style in Chrome.mov
4.1 MB View Download

Sign in to add a comment