UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce the problem:
1. Build Chromium with GCC 8.2.0.
2. 
3. 

What is the expected behavior?
Successful build.

What went wrong?
Failed build.

Did this work before? N/A 

Chrome version: 70.0.3538.9  Channel: dev
OS Version: 
Flash Version: 

Building Chromium 70.0.3538.9 with GCC causes two more problems compared to 70.0.3534.4. This particular error is a recent addition: <https://chromium.googlesource.com/chromium/src/+/9d834f393e035b7dab36e7985d830eaab7dfca8b>. GCC does not like the fact that an unqualified name identical to the function name is used in the declaration of that function. Either the function needs to be renamed to get GCC to accept it, or the spelling of the return type needs to be altered. The attached patch uses a qualified name and (aside from the unrelated errors reported separately) lets the build succeed.

From my build log:
[...]
FAILED: obj/third_party/blink/renderer/core/input/input/pointer_event_manager.o 
g++-8.2.0 -MMD -MF obj/third_party/blink/renderer/core/input/input/pointer_event_manager.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DWTF_USE_WEBAUDIO_FFMPEG=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DV8_DEPRECATION_WARNINGS -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Igen/angle -I../../third_party/libjpeg_turbo -I../../v8/include -Igen/v8/include -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -m64 -march=x86-64 -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fvisibility=hidden -g0 -I/usr/lib64/libffi-3.2.1/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -DLIBXML_STATIC= -std=gnu++14 -Wno-narrowing -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -mtune=generic -O2 -c ../../third_party/blink/renderer/core/input/pointer_event_manager.cc -o obj/third_party/blink/renderer/core/input/input/pointer_event_manager.o
[...]
In file included from ../../third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h:13,
                 from ../../third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.h:13,
                 from ../../third_party/blink/renderer/platform/graphics/paint/property_tree_state.h:8,
                 from ../../third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.h:8,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_chunk.h:14,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_artifact.h:10,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_controller.h:18,
                 from ../../third_party/blink/renderer/platform/graphics/graphics_layer.h:51,
                 from ../../third_party/blink/renderer/core/page/page_overlay.h:34,
                 from ../../third_party/blink/renderer/core/page/page.h:36,
                 from ../../third_party/blink/renderer/core/frame/event_handler_registry.h:9,
                 from ../../third_party/blink/renderer/core/input/pointer_event_manager.cc:14:
../../third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h: At global scope:
../../third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h:104:3: error: declaration of 'base::Optional<cc::SnapContainerData> blink::ScrollPaintPropertyNode::SnapContainerData() const' [-fpermissive]
   }
   ^
In file included from ../../third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.h:17,
                 from ../../third_party/blink/renderer/platform/graphics/paint/transform_paint_property_node.h:13,
                 from ../../third_party/blink/renderer/platform/graphics/paint/clip_paint_property_node.h:13,
                 from ../../third_party/blink/renderer/platform/graphics/paint/property_tree_state.h:8,
                 from ../../third_party/blink/renderer/platform/graphics/paint/ref_counted_property_tree_state.h:8,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_chunk.h:14,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_artifact.h:10,
                 from ../../third_party/blink/renderer/platform/graphics/paint/paint_controller.h:18,
                 from ../../third_party/blink/renderer/platform/graphics/graphics_layer.h:51,
                 from ../../third_party/blink/renderer/core/page/page_overlay.h:34,
                 from ../../third_party/blink/renderer/core/page/page.h:36,
                 from ../../third_party/blink/renderer/core/frame/event_handler_registry.h:9,
                 from ../../third_party/blink/renderer/core/input/pointer_event_manager.cc:14:
../../third_party/blink/renderer/platform/scroll/scroll_snap_data.h:22:48: error: changes meaning of 'SnapContainerData' from 'using SnapContainerData = class cc::SnapContainerData' [-fpermissive]
 using SnapContainerData = cc::SnapContainerData;
                                                ^
[...]
 

Deleted: chromium-blink-snapcontainerdata.patch 469 bytes

chromium-blink-snapcontainerdata.patch 469 bytes Download