XmlUnitTestResultPrinter can produce invalid xml |
|||
Issue descriptionIf this line is reached: https://cs.chromium.org/chromium/src/base/test/gtest_xml_unittest_result_printer.cc?rcl=6e2e384b482bd32c5bc0b037184e9e6311796673&l=116 we get a line in the xml that looks like: <x-test-result-part type="failure" file="<unknown>" line="0"> which is not valid xml because of the angle brackets in <unknown>. This happens if there are too many ASSERT/EXPECT failures in a test.
,
Sep 8
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93df0473e3e9ca1797cf9c927d770eaace2030a4 commit 93df0473e3e9ca1797cf9c927d770eaace2030a4 Author: Frank Henigman <fjhenigman@chromium.org> Date: Wed Sep 12 17:14:00 2018 Produce valid XML in XmlUnitTestResultPrinter. Don't put angle brackets in an attribute value. BUG= chromium:882097 Change-Id: Ib0921e3849a91198c32e93b16d108242937c19db Reviewed-on: https://chromium-review.googlesource.com/1214696 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#590735} [modify] https://crrev.com/93df0473e3e9ca1797cf9c927d770eaace2030a4/base/test/gtest_xml_unittest_result_printer.cc
,
Sep 13
Big thank you Frank for fixing this long-standing bug. Now angle_end2end_tests failures on Windows don't seem to explode and cause infra failures. |
|||
►
Sign in to add a comment |
|||
Comment 1 by fjhenigman@chromium.org
, Sep 8Status: Started (was: Untriaged)