New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 882094 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

master-chromium-pfq not launching new jobs

Project Member Reported by achuith@chromium.org, Sep 8

Issue description

Cc: lannm@google.com
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Owner: mikenichols@chromium.org
Status: Assigned (was: Untriaged)
Wrong component otherwise the oncaller might have seen this this weekend. Adjusted and over to current/future oncallers. 
Owner: no...@chromium.org
nodir@: This is a regression we're seeing after rolling depot_tools in crrev.com/c/1211182
Labels: Foundation-Troopers
+Foundation Troopers
Owner: ----
Status: Available (was: Assigned)
Unassigning for trooper queue
Cc: no...@chromium.org
Owner: no...@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/11bc3991530da45f0dbe80e8eb773e811c9fb107

commit 11bc3991530da45f0dbe80e8eb773e811c9fb107
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 19:07:10 2018

[bot_update] add ignore_input_commit parameter

CrOS chromium-pfq builder uses bot_update, but checks out Chromium on its own,
effectively ignoring input commit in bot_update.
To resolve a P0, add ignore_input_commit parameter.
Long term, bot_update API must be redesigned.

TBR=tandrii@chromium.org
Bug:  882094 
Change-Id: I4f43348e3d5f81bf603dd2c110829bce58acad16
Reviewed-on: https://chromium-review.googlesource.com/1216787
Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/11bc3991530da45f0dbe80e8eb773e811c9fb107/recipes/recipe_modules/bot_update/api.py

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff075d73476a80b1e6ef330c0e12fb31afa841b9

commit ff075d73476a80b1e6ef330c0e12fb31afa841b9
Author: Nodir Turakulov <nodir@google.com>
Date: Mon Sep 10 19:25:15 2018

[chromite] Pass ignore_input_commit=True

Pass ignore_input_commit=True in bot_update.ensure_checkout call because
gclient_conifg always specifies a revision for the first solution and
currently effectively always ignores the input commit.

Bug:  882094 
Change-Id: I712a116cb7b4f7408fa7dc7c4a4ceafff25d7a21
Reviewed-on: https://chromium-review.googlesource.com/1216788
Reviewed-by: Lann Martin <lannm@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/ff075d73476a80b1e6ef330c0e12fb31afa841b9/scripts/slave/recipe_modules/chromite/api.py

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1809fefe1381d602f88d1d080d37ecd1ef6fd59b

commit 1809fefe1381d602f88d1d080d37ecd1ef6fd59b
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 21:19:05 2018

Roll src/third_party/depot_tools d91f0adca280..11bc3991530d (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d91f0adca280..11bc3991530d


git log d91f0adca280..11bc3991530d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 nodir@google.com [bot_update] add ignore_input_commit parameter


Created with:
  gclient setdep -r src/third_party/depot_tools@11bc3991530d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:882094 
TBR=agable@chromium.org

Change-Id: I189dbf46abcf77ef9ad2fb1362d82c03777f67a2
Reviewed-on: https://chromium-review.googlesource.com/1216868
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590066}
[modify] https://crrev.com/1809fefe1381d602f88d1d080d37ecd1ef6fd59b/DEPS

Sign in to add a comment