Extensions: don't use *plain_background rather than drawing it ourselves |
|
Issue descriptionThe resources EXTENSION_ACTION_PLAIN_BACKGROUND and EXTENSION_ICON_PLAIN_BACKGROUND are almost entirely just a grey square, but with slightly rounded-ish corners. This seems like the time of thing we could draw programmatically, rather than with assets. bklmn@, can you give us an appropriate indication of what this should be? (with the refresh, should it still have rounded corners, etc?)
,
Sep 20
I think these were the assets, https://cs.chromium.org/chromium/src/extensions/browser/resources/default_100_percent/extension_action_plain_background.png?sq=package:chromium&dr&g=0 https://cs.chromium.org/chromium/src/extensions/browser/resources/default_100_percent/extension_icon_plain_background.png?sq=package:chromium&dr&g=0
,
Sep 20
Thanks. I imagine these could all prob need an update...not sure if these assets are still relevant with the new GM2 hover/press states in the core UI. Im glad to give new assets and or details to draw programmatically. What exact scenarios are these "plain_background" assets being used? (sorry for my ignorance on this)
,
Sep 20
Devlin can probably elaborate more, but the plain backgrounds are used for the extension placeholder icon in either the favicon or the browser action button in the toolbar. https://cs.chromium.org/chromium/src/extensions/browser/extension_icon_placeholder.cc?l=55-61 |
|
►
Sign in to add a comment |
|
Comment 1 by bklmn@chromium.org
, Sep 20