New issue
Advanced search Search tips

Issue 882090 link

Starred by 2 users
Status: Duplicate
Merged: issue 376840
Owner:
markchang@chromium.org
Closed: Sep 8
Cc:
rdevlin....@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

(Ctrl | Comand) + W should not close a pinned tab

Project Member Reported by rdevlin....@chromium.org, Sep 8 
What steps will reproduce the problem?
1. Pin a tab
2. Press Ctrl + w on a non-Mac machine; Cmd + w on a Mac machine

What is the expected result?
Given the tab is pinned, and we remove the 'x' button to close the tab, I wouldn't expect a hotkey like Ctrl + W to close the tab.

What happens instead of that?
The tab closes.

This is just my $0.02, but I feel like "pinned" tabs shouldn't respond to "normal" closures (because "pinning" indicates "I want this tab to stay around!").

Over to markchang@ for input, triage, etc.

Comment 1 by pkasting@chromium.org, Sep 8 

I feel like we've discussed this before, but I'm not sure where.  IMO, this should be wontfix for the same reason we allow navigations to overwrite pinned tabs: pinning a tab is primarily about making sure it is at a certain position in your strip, not protecting it against all possible destruction.  That is, this is about tab prioritization and ordering rather than preservation.

If ctrl-w accidentally closes a pinned tab, to me the answer is "we should make sure every user can figure out how to undo closing the tab, and it gets state back perfectly".  Neither of those is true today (and I can think of ways to improve them); I would put time into those.

Comment 2 by sky@chromium.org, Sep 8

Mergedinto: 376840
Status: Duplicate (was: Assigned)
See also  bug 66588  for some discussion as well.
►

Sign in to add a comment