New issue
Advanced search Search tips

Issue 882084 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 877791
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in v8::internal::compiler::RegisterAllocatorVerifier::DelayedAssessments::AddDelaye

Project Member Reported by ClusterFuzz, Sep 8

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5153121645625344

Fuzzer: binaryen_wasm_fuzzer
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: Ill
Crash Address: 0xf255fed7
Crash State:
  v8::internal::compiler::RegisterAllocatorVerifier::DelayedAssessments::AddDelaye
  v8::internal::compiler::RegisterAllocatorVerifier::ValidatePendingAssessment
  v8::internal::compiler::RegisterAllocatorVerifier::ValidateUse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm_dbg&range=51674:51675

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5153121645625344

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 8

Components: Blink>JavaScript>Compiler
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 8

Labels: Test-Predator-Auto-Owner
Owner: gdeepti@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/ad3d0ba83cc416b017a09fa22bd8c277c8862adb ([wasm] Add I64 Atomic binary operations for x64).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>JavaScript -Blink>JavaScript>Compiler Blink>JavaScript>WebAssembly
Cc: gdeepti@chromium.org
Owner: ahaas@chromium.org
My expectation of this test is that it should fail with a compile error, but this crashes in code-gen instead. 

I suspect there's a potential race when using background compilation as using --num-wasm-compilation-tasks=0 behaves correctly. When using background threads, Liftoff identifies that there is a compile error, then falls through to Turbofan, Turbofan compiles, and identifies that there is a failure to create the graph, but continues to fetch and compile other units. Is there a reason this can't fail early when a compile error is encountered and should wait till the FinishCompilation phase? ahaas@, could you take a look?  
Cc: clemensh@chromium.org ahaas@chromium.org
 Issue 853412  has been merged into this issue.
Project Member

Comment 6 by ClusterFuzz, Sep 20

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5017242522353664 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by ClusterFuzz, Sep 27

Labels: Needs-Feedback
ClusterFuzz testcase 4711625400254464 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Mergedinto: 877791
Status: Duplicate (was: Verified)
Project Member

Comment 9 by ClusterFuzz, Oct 4

ClusterFuzz has detected this issue as fixed in range 56359:56360.

Detailed report: https://clusterfuzz.com/testcase?key=5153121645625344

Fuzzer: binaryen_wasm_fuzzer
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: Ill
Crash Address: 0xf255fed7
Crash State:
  v8::internal::compiler::RegisterAllocatorVerifier::DelayedAssessments::AddDelaye
  v8::internal::compiler::RegisterAllocatorVerifier::ValidatePendingAssessment
  v8::internal::compiler::RegisterAllocatorVerifier::ValidateUse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm_dbg&range=51674:51675
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm_dbg&range=56359:56360

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5153121645625344

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment