New issue
Advanced search Search tips

Issue 882080 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

wide frame becomes invisible after switching from fullscreen to maximzied

Project Member Reported by osh...@chromium.org, Sep 8

Issue description

Repro step:
* start snapchat
* maximzie it
* hit fullscreen key
* hit fullscreen key again
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7585ab55996075391f34dba387978740039f2ef3

commit 7585ab55996075391f34dba387978740039f2ef3
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sat Sep 08 02:43:55 2018

Layout the wide frame when exiting immersive fullscreen

Since the wide frame doesn't have the content,
relayout doesn't happen automatically.

Bug:  882080 
Test: manual
Change-Id: Ia24a4d71a3f7b74834cc423fbdf87d096231b1f2
Reviewed-on: https://chromium-review.googlesource.com/1214687
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589758}
[modify] https://crrev.com/7585ab55996075391f34dba387978740039f2ef3/ash/frame/wide_frame_view.cc

Labels: Merge-Request-70
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 9

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf6ee7c05bd4ef9bb5372c3eed5dee98e62ce7b

commit 0cf6ee7c05bd4ef9bb5372c3eed5dee98e62ce7b
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Sep 10 14:52:28 2018

Layout the wide frame when exiting immersive fullscreen

Since the wide frame doesn't have the content,
relayout doesn't happen automatically.

Bug:  882080 
Test: manual
Change-Id: Ia24a4d71a3f7b74834cc423fbdf87d096231b1f2
Reviewed-on: https://chromium-review.googlesource.com/1214687
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589758}(cherry picked from commit 7585ab55996075391f34dba387978740039f2ef3)
Reviewed-on: https://chromium-review.googlesource.com/1216463
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#213}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/0cf6ee7c05bd4ef9bb5372c3eed5dee98e62ce7b/ash/frame/wide_frame_view.cc

Status: Fixed (was: Started)

Sign in to add a comment