New issue
Advanced search Search tips

Issue 882063 link

Starred by 2 users
Status: Fixed
Owner:
minch@chromium.org
Closed: Dec 13
Cc:
omrilio@chromium.org
shibasheikh@chromium.org
kaznacheev@chromium.org
mccanny@chromium.org
kejiashao@chromium.org
zork@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
shelf-auto-hide


Sign in to add a comment

Drag launcher from auto-hide-shown shelf in clamshell mode

Project Member Reported by minch@chromium.org, Sep 8 
What steps will reproduce the problem?
(1) Set shelf to "Autohide shelf".
(2) Swipe up to show the simple shelf.
(3) Swipe up again on the shown simple shelf.


1. If launcher has not been dragged high enough, it will fall back to close. Shelf will also be hidden in this case.
Is this expected? Or should keep shelf still shown even launcher has been opened.

2. If launcher has been dragged to open, shelf will be kept shown. But if tap/drag down the opened launcher.
Shelf and launcher will be closed at the same time.
Close the launcher at tapping/dragging down enough is the expected behavior. How about the simple shelf in this case? Should still keep it shown?

Comment 1 by mccanny@chromium.org, Sep 8

Cc: sgabr...@chromium.org shibasheikh@chromium.org
Adding more designers for their opinions.

1. I think we should keep the shelf around on failed launcher drag.

2. I could go either way with this one, but lean towards hiding the shelf on launcher close.

Comment 2 by sgabr...@chromium.org, Sep 8 

I'm having some issues representing exactly what's happening there but based on my understanding, I'd tend to agree with Ben.

Comment 3 by shibasheikh@chromium.org, Sep 10 

Yup, makes sense to me:

1. Show simple shelf
2. Hide shelf when Launcher closes

Comment 4 by newcomer@chromium.org, Sep 13

Labels: M-71

Comment 5 by newcomer@chromium.org, Oct 15

Labels: m-72
Bulk moving all M-71 <P-1's to M-72.

Comment 6 by newcomer@chromium.org, Oct 15

Labels: -M-71 -m-71

Comment 7 by newcomer@chromium.org, Dec 3

Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.

Comment 8 by newcomer@chromium.org, Dec 5 

Issue 902680 has been merged into this issue.

Comment 9 by newcomer@chromium.org, Dec 5

Labels: -Pri-2 -M-73 M-72 Pri-1
Marking as a P-1 for m-72, like it's duplicate.

Comment 10 by minch@chromium.org, Dec 10

Status: Started (was: Assigned)

Comment 11 by minch@chromium.org, Dec 10

Labels: -M-72 M-73
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3328547d33e24a9cb7f2e941f58fcf4f84b1f1a4

commit 3328547d33e24a9cb7f2e941f58fcf4f84b1f1a4
Author: Min Chen <minch@google.com>
Date: Thu Dec 13 23:36:26 2018

shelf: Keep shelf visible if failed to drag up app list from it.

Bug:  882063 
Change-Id: Id49140eb4e16fe2bef1e337cb67a5cf7cc8867d5
Reviewed-on: https://chromium-review.googlesource.com/c/1377169
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616490}
[modify] https://crrev.com/3328547d33e24a9cb7f2e941f58fcf4f84b1f1a4/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/3328547d33e24a9cb7f2e941f58fcf4f84b1f1a4/ash/shelf/shelf_layout_manager_unittest.cc

Comment 13 by minch@chromium.org, Dec 13

Status: Fixed (was: Started)
►

Sign in to add a comment